fix: Display name is not validated properly (UI part) #14142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not use the `alphanumericalExpanded: /^$|^[a-zA-Z0-9\-_\.\u0020]+$/` regex which contains the dot (`.`) character too; be explicit here and do what the error message says - the space character at start/end is validated above with the `startsWithSpaceValidator` CHERRY-PICK-TO: 2.28 Fixes #14127
caybro
requested review from
jrainville,
stefandunca,
alexjba,
noeliaSD and
osmaczko
Jenkins Builds
|
|
I wonder if I could reuse the existing: readonly property var alphanumericalExpanded1: /^[a-zA-Z0-9\-_]+(?: [a-zA-Z0-9\-_]+)*$/here... |
alexjba
approved these changes
Mar 25, 2024
osmaczko
approved these changes
Mar 25, 2024
jrainville
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
alphanumericalExpanded: /^$|^[a-zA-Z0-9\-_\.\u0020]+$/regex which contains the dot (.) character too; be explicit here and do what the error message saysstartsWithSpaceValidatorCHERRY-PICK-TO: 2.28
Fixes #14127
Affected areas
Display name validation
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-03-25.14-08-04.webm