Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick fix: Display name is not validated properly (UI part) #14153

Conversation

caybro
Copy link
Member

@caybro caybro commented Mar 25, 2024

Cherry-pick of #14142

What does the PR do

  • do not use the alphanumericalExpanded: /^$|^[a-zA-Z0-9\-_\.\u0020]+$/ regex which contains the dot (.) character too; be explicit here and do what the error message says
  • the space character at start/end is validated above with the startsWithSpaceValidator

Fixes #14127

- do not use the `alphanumericalExpanded:
/^$|^[a-zA-Z0-9\-_\.\u0020]+$/` regex which contains the dot (`.`)
character too; be explicit here and do what the error message says
- the space character at start/end is validated above with the
`startsWithSpaceValidator`

CHERRY-PICK-TO: 2.28

Fixes #14127
@caybro caybro requested review from iurimatias and jrainville March 25, 2024 18:16
@caybro caybro changed the title fix: Display name is not validated properly (UI part) cherry-pick fix: Display name is not validated properly (UI part) Mar 25, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 25, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9541fa2 #1 2024-03-25 18:23:06 ~6 min tests/nim 📄log
✔️ 9541fa2 #1 2024-03-25 18:23:32 ~6 min macos/aarch64 🍎dmg
✔️ 9541fa2 #1 2024-03-25 18:28:02 ~11 min tests/ui 📄log
✔️ 9541fa2 #1 2024-03-25 18:29:12 ~12 min macos/x86_64 🍎dmg
✔️ 9541fa2 #1 2024-03-25 18:34:20 ~17 min linux/x86_64 📦tgz
✔️ 9541fa2 #1 2024-03-25 18:40:59 ~24 min windows/x86_64 💿exe

@caybro caybro requested a review from osmaczko March 25, 2024 18:38
@jrainville jrainville merged commit c26110c into release/2.28.x Mar 25, 2024
8 checks passed
@jrainville jrainville deleted the fix/14127-display-name-is-not-validated-properly-ui-part-2.28 branch March 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants