Don't panic if config is nil in community #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (24)
|
osmaczko
approved these changes
Jul 12, 2023
cammellos
force-pushed
the
bug/avoid-panic-in-has-permissions
branch
from
f15b878
to
26595da
Compare
cammellos
force-pushed
the
bug/avoid-panic-in-has-permissions
branch
2 times, most recently
from
d910902
to
d1ec653
Compare
I have encountered a crash in the app after syncing, looks like a community has been created without a Config. This crashes the app after the user logs in. This commit prevents the app from crashing, but does not fix the underlaying issue (that's something I will have to investigate). Added tests to validate the behavior. Check community exists
cammellos
force-pushed
the
bug/avoid-panic-in-has-permissions
branch
from
d1ec653
to
2729f28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have encountered a crash in the app after syncing, looks like a community has been created without a Config.
This crashes the app after the user logs in.
This commit prevents the app from crashing, but does not fix the underlaying issue (that's something I will have to investigate). Added tests to validate the behavior.