Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panic when config missing in community #16572

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Avoid panic when config missing in community #16572

merged 1 commit into from
Jul 14, 2023

Conversation

cammellos
Copy link
Contributor

status-go pr: status-im/status-go#3743

@cammellos cammellos self-assigned this Jul 12, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jul 12, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (18)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 3d369d8 #1 2023-07-12 13:49:31 ~4 min tests 📄log
✔️ 3d369d8 #1 2023-07-12 13:53:56 ~9 min android-e2e 🤖apk 📲
✔️ 3d369d8 #1 2023-07-12 13:54:04 ~9 min android 🤖apk 📲
❌ 8b35a91 #2 2023-07-12 14:28:16 ~3 min tests 📄log
✔️ 8b35a91 #2 2023-07-12 14:32:50 ~8 min android-e2e 🤖apk 📲
✔️ 8b35a91 #2 2023-07-12 14:34:05 ~9 min android 🤖apk 📲
✔️ fbda7b5 #3 2023-07-12 14:48:30 ~11 min android-e2e 🤖apk 📲
✔️ fbda7b5 #3 2023-07-12 14:48:34 ~11 min android 🤖apk 📲
✔️ fbda7b5 #3 2023-07-12 14:49:05 ~12 min tests 📄log
✔️ fbda7b5 #3 2023-07-12 15:03:34 ~26 min ios 📱ipa 📲
✔️ 3452338 #4 2023-07-13 08:56:43 ~11 min android-e2e 🤖apk 📲
✔️ 3452338 #4 2023-07-13 08:56:47 ~11 min android 🤖apk 📲
✔️ 3452338 #4 2023-07-13 08:57:23 ~12 min tests 📄log
✔️ 3452338 #4 2023-07-13 09:07:47 ~22 min ios 📱ipa 📲
✔️ e5f5e1c #6 2023-07-13 14:21:02 ~8 min android 🤖apk 📲
✔️ e5f5e1c #6 2023-07-13 14:21:20 ~8 min ios 📱ipa 📲
✔️ e5f5e1c #6 2023-07-13 14:23:43 ~10 min android-e2e 🤖apk 📲
✔️ e5f5e1c #6 2023-07-13 14:24:48 ~11 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d86e5d2 #7 2023-07-13 14:46:07 ~9 min android-e2e 🤖apk 📲
✔️ d86e5d2 #7 2023-07-13 14:46:08 ~9 min android 🤖apk 📲
✔️ d86e5d2 #7 2023-07-13 14:46:53 ~9 min tests 📄log
✔️ d86e5d2 #7 2023-07-13 14:59:21 ~22 min ios 📱ipa 📲
✔️ 2b0ea01 #8 2023-07-14 07:38:15 ~11 min tests 📄log
✔️ 2b0ea01 #8 2023-07-14 07:38:54 ~12 min android 🤖apk 📲
✔️ 2b0ea01 #8 2023-07-14 07:38:59 ~12 min android-e2e 🤖apk 📲
✔️ 2b0ea01 #8 2023-07-14 07:46:25 ~19 min ios 📱ipa 📲

@cammellos cammellos force-pushed the bug/avoid-panic-in-has-permissions branch 2 times, most recently from 8b35a91 to fbda7b5 Compare July 12, 2023 14:36
@churik churik self-assigned this Jul 12, 2023
@churik
Copy link
Member

churik commented Jul 12, 2023

@cammellos can't sync with the latest master desktop
logs (49).zip

IMG_6546.MP4

@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 34
Failed tests: 2
Passed tests: 32
Not executed tests: 2

IDs of not executed tests: 703391,703297 

IDs of failed tests: 702731,702732

Not executed tests (2)

Click to expand
  • Rerun not executed tests

    • Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (32)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859
    Device sessions

    2. test_community_message_edit, id: 702843
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    6. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_several_images_send_reply, id: 703194
    Device sessions

    9. test_community_leave, id: 702845
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    11. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    12. test_community_message_delete, id: 702839
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    6. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    7. test_1_1_chat_edit_message, id: 702855
    Device sessions

    8. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_mentions, id: 702957
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @cammellos cammellos force-pushed the bug/avoid-panic-in-has-permissions branch from fbda7b5 to 3452338 Compare July 13, 2023 08:44
    @churik
    Copy link
    Member

    churik commented Jul 13, 2023

    @cammellos #16572 (comment) is reproducible every time, but only on IOS

    @cammellos cammellos force-pushed the bug/avoid-panic-in-has-permissions branch 3 times, most recently from e5f5e1c to d86e5d2 Compare July 13, 2023 14:36
    @cammellos cammellos force-pushed the bug/avoid-panic-in-has-permissions branch from d86e5d2 to 2b0ea01 Compare July 14, 2023 07:26
    @cammellos cammellos merged commit 2b0ea01 into develop Jul 14, 2023
    @cammellos cammellos deleted the bug/avoid-panic-in-has-permissions branch July 14, 2023 07:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    Assignees

    @cammellos cammellos

    @churik churik

    Labels
    Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @cammellos @status-im-auto @churik @Parveshdhull @J-Son89