Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Resolve ENS domains in browser #4772

Closed
rachelhamlin opened this issue Jun 14, 2018 · 5 comments · Fixed by #5708
Closed

[Draft] Resolve ENS domains in browser #4772

rachelhamlin opened this issue Jun 14, 2018 · 5 comments · Fixed by #5708
Assignees

Comments

@rachelhamlin
Copy link
Contributor

User Story

As a user, I want to browse the fully decentralized web and load content from p2p storage platforms like IPFS and Swarm in the Status browser.

Description

Type: Feature

Summary: Resolve ENS domains to IPFS/Swarm hashes and redirect to content.

Expected behavior

Entering a .eth address into the Status URL bar will redirect to the associated content.

Actual behavior

The browser can not resolve .eth addresses.

@bgits
Copy link

bgits commented Jun 14, 2018

Example implementation via metamask:
MetaMask/metamask-extension#4405

Tutorial for above implementation:
https://gist.github.com/PhyrexTsai/cffcbfa1d752b9cf817d920dfcd1ec9f

Gist
GitHub is where people build software. More than 28 million people use GitHub to discover, fork, and contribute to over 85 million projects.

@jeluard
Copy link
Contributor

jeluard commented Aug 14, 2018

Some notes:

IPFS and SWARM won't be resolved directly (but can be via their respective http gateways).

It has to be decided if we want to go full multishash directly (EIP1062) or first settle on getContent resolving to IPFS hashes (what MetaMask supports for now).

IMO it makes sense to go with option #2 as it supports existing resolvers and matches MetaMask behavior.

Sub resources (e.g. local images, JS and CSS) must be resolved accordingly. Roman pointed out the entry point for android and iOS.

@bgits
Copy link

bgits commented Aug 14, 2018

@jeluard These are fair points. IMO it's still better to have baby steps in that direction and use gateways than the current more centralized alternatives.

What are the issues with supporting multihash?
It's already been added to the latest version of the Public Resolver:
https://github.com/ensdomains/ens/blob/master/contracts/PublicResolver.sol#L90

GitHub
ens - Implementations for registrars and local resolvers for the Ethereum Name Service

@jeluard
Copy link
Contributor

jeluard commented Aug 14, 2018

@bgits Just modified my comment :) Here is what I added : IMO it makes sense to go with option #2 as it supports existing resolvers and matches MetaMask behavior.

@rachelhamlin
Copy link
Contributor Author

@flexsurfer I would second @jeluard here and say we follow the MetaMask implementation for now.

@flexsurfer flexsurfer self-assigned this Aug 17, 2018
flexsurfer added a commit that referenced this issue Sep 3, 2018
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants