[#4772] Resolve ENS domains in browser #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goranjovic
reviewed
Aug 30, 2018
deps.edn
Outdated
| @@ -10,7 +10,8 @@ | |||
| com.andrewmcveigh/cljs-time {:mvn/version "0.5.2"} | |||
| com.taoensso/timbre {:mvn/version "4.10.0"} | |||
| hickory {:mvn/version "0.7.1"} | |||
| com.cognitect/transit-cljs {:mvn/version "0.8.248"}} | |||
| com.cognitect/transit-cljs {:mvn/version "0.8.248"} | |||
| mvxcvi/multihash {:mvn/version "2.0.3"}} | |||
There was a problem hiding this comment.
why do we need a new dependency?
There was a problem hiding this comment.
to work with multihashes
There was a problem hiding this comment.
So I take it there is no way to inline that functionality? Every dep increases our attack surface
There was a problem hiding this comment.
anyway it can't be compiled
Compiling ["index.desktop.js"] from ["components/src" "react-native/src/cljsjs" "react-native/src/desktop" "src" "env/prod"]...
[31mWARNING[0m: Extending an existing JavaScript type - use a different symbol name instead of js/String e.g string at line 246 target/desktop-prod/multihash/core.cljc
Error encountered performing task 'cljsbuild' with profile(s): 'prod'
jeluard
reviewed
Aug 30, 2018
| (def resolver-abi (js* "[{'constant': true, 'inputs': [{'name': 'interfaceID', 'type': 'bytes4'}], 'name': 'supportsInterface', 'outputs': [{'name': '', 'type': 'bool'}], 'payable': false, 'type': 'function'}, {'constant': true, 'inputs': [{'name': 'node', 'type': 'bytes32'}, {'name': 'contentTypes', 'type': 'uint256'}], 'name': 'ABI', 'outputs': [{'name': 'contentType', 'type': 'uint256'}, {'name': 'data', 'type': 'bytes'}], 'payable': false, 'type': 'function'}, {'constant': false, 'inputs': [{'name': 'node', 'type': 'bytes32'}, {'name': 'x', 'type': 'bytes32'}, {'name': 'y', 'type': 'bytes32'}], 'name': 'setPubkey', 'outputs': [], 'payable': false, 'type': 'function'}, {'constant': true, 'inputs': [{'name': 'node', 'type': 'bytes32'}], 'name': 'content', 'outputs': [{'name': 'ret', 'type': 'bytes32'}], 'payable': false, 'type': 'function'}, {'constant': true, 'inputs': [{'name': 'node', 'type': 'bytes32'}], 'name': 'addr', 'outputs': [{'name': 'ret', 'type': 'address'}], 'payable': false, 'type': 'function'}, {'constant': false, 'inputs': [{'name': 'node', 'type': 'bytes32'}, {'name': 'contentType', 'type': 'uint256'}, {'name': 'data', 'type': 'bytes'}], 'name': 'setABI', 'outputs': [], 'payable': false, 'type': 'function'}, {'constant': true, 'inputs': [{'name': 'node', 'type': 'bytes32'}], 'name': 'name', 'outputs': [{'name': 'ret', 'type': 'string'}], 'payable': false, 'type': 'function'}, {'constant': false, 'inputs': [{'name': 'node', 'type': 'bytes32'}, {'name': 'name', 'type': 'string'}], 'name': 'setName', 'outputs': [], 'payable': false, 'type': 'function'}, {'constant': false, 'inputs': [{'name': 'node', 'type': 'bytes32'}, {'name': 'hash', 'type': 'bytes32'}], 'name': 'setContent', 'outputs': [], 'payable': false, 'type': 'function'}, {'constant': true, 'inputs': [{'name': 'node', 'type': 'bytes32'}], 'name': 'pubkey', 'outputs': [{'name': 'x', 'type': 'bytes32'}, {'name': 'y', 'type': 'bytes32'}], 'payable': false, 'type': 'function'}, {'constant': false, 'inputs': [{'name': 'node', 'type': 'bytes32'}, {'name': 'addr', 'type': 'address'}], 'name': 'setAddr', 'outputs': [], 'payable': false, 'type': 'function'}, {'inputs': [{'name': 'ensAddr', 'type': 'address'}], 'payable': false, 'type': 'constructor'}, {'anonymous': false, 'inputs': [{'indexed': true, 'name': 'node', 'type': 'bytes32'}, {'indexed': false, 'name': 'a', 'type': 'address'}], 'name': 'AddrChanged', 'type': 'event'}, {'anonymous': false, 'inputs': [{'indexed': true, 'name': 'node', 'type': 'bytes32'}, {'indexed': false, 'name': 'hash', 'type': 'bytes32'}], 'name': 'ContentChanged', 'type': 'event'}, {'anonymous': false, 'inputs': [{'indexed': true, 'name': 'node', 'type': 'bytes32'}, {'indexed': false, 'name': 'name', 'type': 'string'}], 'name': 'NameChanged', 'type': 'event'}, {'anonymous': false, 'inputs': [{'indexed': true, 'name': 'node', 'type': 'bytes32'}, {'indexed': true, 'name': 'contentType', 'type': 'uint256'}], 'name': 'ABIChanged', 'type': 'event'}, {'anonymous': false, 'inputs': [{'indexed': true, 'name': 'node', 'type': 'bytes32'}, {'indexed': false, 'name': 'x', 'type': 'bytes32'}, {'indexed': false, 'name': 'y', 'type': 'bytes32'}], 'name': 'PubkeyChanged', 'type': 'event'}]")) | ||
| (def default-address "0x0000000000000000000000000000000000000000") | ||
| (def default-hash "0x0000000000000000000000000000000000000000000000000000000000000000") | ||
|
|
There was a problem hiding this comment.
Why this? Can't we do the same way as it's done for others field in the ens namespace?
There was a problem hiding this comment.
it's temporary solutions while #5459 not merged
There was a problem hiding this comment.
oh right if we're going with content field we can use same way
| (handlers/register-handler-fx | ||
| :browse-link-from-message | ||
| (fn [_ [_ link]] | ||
| {:browse link})) | ||
|
|
||
| (handlers/register-handler-fx | ||
| :ens-multihash-resolved |
There was a problem hiding this comment.
So we are supporting multihash?
There was a problem hiding this comment.
yes but it's stored in content field
flexsurfer
force-pushed
the
feature/browser-ens-support
branch
from
c86fbb3
to
f22356b
Compare
goranjovic
approved these changes
Aug 30, 2018
jeluard
approved these changes
Aug 30, 2018
yenda
reviewed
Aug 30, 2018
| (handlers/register-handler-fx | ||
| :browse-link-from-message | ||
| (fn [_ [_ link]] | ||
| {:browse link})) | ||
|
|
||
| (handlers/register-handler-fx | ||
| :ens-multihash-resolved | ||
| [re-frame/trim-v] |
There was a problem hiding this comment.
can you clean up the trim-v co-effect, we are removing them to have a more consistent codebase
| (handlers/register-handler-fx | ||
| :ens-multihash-resolved | ||
| [re-frame/trim-v] | ||
| (fn [{:keys [db] :as cofx} [hash]] |
There was a problem hiding this comment.
ideally events should be one-liners that call a function from the models
flexsurfer
force-pushed
the
feature/browser-ens-support
branch
from
f22356b
to
20e573e
Compare
88% of end-end tests have passedFailed tests (7)Click to expand
Passed tests (51)Click to expand
|
|
I have tried to resolve some of those addresses: http://phyrextsai.eth for now, current implementation looks like this (infura link is shown in the browser)
https://ipfs.infura.io/ipfs/QmUpAghbXaytas97onhD48h1FN73JWTL5PBoBoaQkXxL9e |
flexsurfer
force-pushed
the
feature/browser-ens-support
branch
from
20e573e
to
61e6089
Compare
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
flexsurfer
force-pushed
the
feature/browser-ens-support
branch
from
61e6089
to
c96bc5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4772