Wallet: selecting keypair #19070
Merged
Wallet: selecting keypair #19070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (82)
|
OmarBasem
force-pushed
the
wallet/keypair-5
branch
from
afdac25
to
abfcfdd
Compare
OmarBasem
requested review from
briansztamfater,
smohamedjavid,
J-Son89,
shivekkhurana,
FFFra,
mmilad75 and
vkjr
J-Son89
reviewed
Mar 5, 2024
src/status_im/contexts/wallet/create_account/select_keypair/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Mar 5, 2024
src/status_im/contexts/wallet/create_account/select_keypair/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Mar 5, 2024
J-Son89
reviewed
Mar 5, 2024
J-Son89
reviewed
Mar 5, 2024
J-Son89
reviewed
Mar 5, 2024
J-Son89
reviewed
Mar 5, 2024
J-Son89
reviewed
Mar 5, 2024
|
Hi @OmarBasem Related to the video in the description: Screen_Recording_20240305_084128_Status.mp4I'm wondering why the new screen opened is white at the beginning, what is the reason? Also, please let's fix the schema errors reported, they appear when the new screen is visited |
ulisesmac
reviewed
Mar 5, 2024
OmarBasem
force-pushed
the
wallet/keypair-5
branch
from
eccbe62
to
8750c9c
Compare
@ulisesmac Thanks for noticing this. Fixed it.
The PR video wasn't rebased. Schema errors are gone after rebasing. |
|
@J-Son89 @ulisesmac rereview please |
ulisesmac
approved these changes
Mar 8, 2024
OmarBasem
force-pushed
the
wallet/keypair-5
branch
from
f788a34
to
654f897
Compare
|
Thanks for your testing @VolodLytvynenko ! I opened a PR that removes the feature flag where the Epic functionalities can be QAed #19333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18993
Epic: #18669
This PR implements selecting keypair and creating a wallet account from an existing keypair.
It also completes the keypair creation Epic.
Designs
Demo:
Screen_Recording_20240305_084128_Status.mp4