Wallet: Keypair feature flag #19333
Merged
Wallet: Keypair feature flag #19333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
|
Hi @Francesca-G, There is a list of PRs in the description above, each includes a video showing what was implemented if you wanted to check that. |
ulisesmac
approved these changes
Mar 19, 2024
90% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (43)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
@OmarBasem I tested out this pr - RPReplay_Final1710889836.movAlso just some questions we might want to bring designers. 
But here the edit button is not visible - as it is in the designs 👍 |
|
working now @OmarBasem, nice one! I wonder should we change the behaviour of disabling edit keypair though? For example, if I create a new key pair, I would expect the edit button is available, however it's not. It's unclear to me what the expectation is here but maybe we should confirm this with design? (perhaps you already have? 🤔 ) |
Francesca-G
reviewed
Mar 20, 2024
OmarBasem
force-pushed
the
wallet/keypair-ff
branch
from
52c47a3
to
30638c9
Compare
@J-Son89 yes, the |
|
Thanks for your review @Francesca-G ! Fixed the issues |
|
Hi @OmarBasem, thank you for your great work. The keypair creation screens look visually very pleasant. However, some issues are found. Take a look at them please: ISSUE 1: Inability to remove ETH account with Generated KeypairsSteps:
Actual result:The removing bottom sheet is not shown bottomsheet.mp4Expected result:The removing bottom sheet should be shown with 'remove' and 'cancel' buttons. |
Question 1:Did I understand correctly the key pair name should be fetched to the About section? Currently, it doesn't and the default name is shown there instead |
Question 2:Should the validation be included in the scope of this PR? Currently, it doesn't work |
ISSUE 2: [IOS] The continue button is not visible on the Keypair screen when keyboard is openedSteps:
Actual result:The "continue" button is hidden under the keyboard keyboard.mp4Expected result:The "continue" button is visible when a keyboard is opened Device:iPhone 11 Pro max, IOS 17 |
Question 3:Should the screenshot preventing page be included in the scope of this PR? Currently, it is not shown |
|
I believe this is a global issue affecting all buttons in the app. Therefore, it might be considered as a follow-up. ISSUE 3: The text within buttons is slightly visible when buttons are in a disabled stateActual result:
Expected result:
|
I'll leave it to @OmarBasem to decide but account removal, about page and validation all seem fine to have as follows up imo 👍 |
OmarBasem
force-pushed
the
wallet/keypair-ff
branch
from
fe0c7b8
to
58c12c5
Compare
|
Thanks for your testing @VolodLytvynenko ! Issues 2 and 4 are fixed. As for account removal, about page, validation, and screenshot prevention I would prefer to do it in a follow up. Regarding issue 3: I think that's a global issue not specific to this PR. A disbaled bottom-action button with white text will look like that in other parts also. We can handle that in a seperate issue.
This is for accounts generated from a private key. Account generated from a keypair can be from a secret phrase or a private key. Currently what we have is keypairs generated from a secret phrases which should use the default modal for regular accounts |
81% of end-end tests have passedFailed tests (8)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (39)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
|
12% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (1)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
|
|
@OmarBasem Thank you for the fixes. Issues 2 and 4 are fixed. All others I will create as a follow ups. PR is ready to be merged. |
OmarBasem
force-pushed
the
wallet/keypair-ff
branch
from
58c12c5
to
b980906
Compare
This was referenced Mar 22, 2024
mmilad75
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Wallet: Keypair feature flag (#19333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18669
This PR removes the feature flag from the keypair feature and completes the epic.
No code changes in this PR other than removing the feature flag.
List of Epic PRs:
Each PR from the above includes a video of what was implemented in that PR.
The following designs link shows the whole flow: Designs