chore: rename alias of promesa to be more verbose #19332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping manual QA here as this pr does not change any code, it only renames the importing of some dependencies. |
Jenkins BuildsClick to see older builds (22)
|
94% of end-end tests have passedFailed tests (2)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
@clauxx can you take a quick look when you get a chance? this pr is straightforward enough |
clauxx
approved these changes
Mar 25, 2024
we can change it later, when all devs will be familiar with it, same as we have rn or rf |
flexsurfer
approved these changes
Mar 25, 2024
alwx
approved these changes
Mar 25, 2024
yeah +1 on this, it's just temporary while devs are becoming familiar with promesa 👍 |
OmarBasem
approved these changes
Mar 25, 2024
|
@J-Son89 hey! E2E are fine here. |
mmilad75
pushed a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr renames the alias of promesa from
ptopromesa. We can look to revisit this in the future but while it is quite new to the codebase it is good to leave it more verbose and apparent to devs of what the code is doing.