fix channel header is broken when opening channel with chat history after joining the community #19677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parveshdhull
commented
Apr 16, 2024
| @@ -132,12 +132,11 @@ | |||
| [all-loaded-sub]) | |||
| [rn/view | |||
| {:style (style/navigation-view navigation-view-height messages.constants/pinned-banner-height)} | |||
| (when (seq last-message) | |||
There was a problem hiding this comment.
don't know why we added this
There was a problem hiding this comment.
From what I can remember, It was a fix for this
There was a problem hiding this comment.
thank you @ibrkhalil for adding context. I am still confused, how last-message relates to shadow 🤔
There was a problem hiding this comment.
Sorry for not being specific, It's the overlapping of the top nav bar with the avatar.
There was a problem hiding this comment.
Thank you. Unfortunately, I am not able to reproduce this overlap, if this ever comes up let's log an issue perhaps with a video to give more context.
Also, I don't think the last message is a proper fix if the top bar overlaps. We should not just remove the top bar when there is no last message. If it overlaps then probably something wrong with the animation, as you can see from the shared image position of an avatar with respect to the close button is wrong.
There was a problem hiding this comment.
I am requesting design review as it was approved on my PR.
Jenkins BuildsClick to see older builds (4)
|
ibrkhalil
approved these changes
Apr 16, 2024
88% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (46)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
|
|
@Parveshdhull thank you for the fix! @Francesca-G could you please review everything related to channel header in this PR? Thank you! |
Francesca-G
reviewed
Apr 17, 2024
There was a problem hiding this comment.
The animation when scrolling looks good, but we have a couple of weird states when the channel is empty:
- This happens when opening the composer:
- This happens when there's enough messages to get the animation "started" but not quite enough to have the full animation:
Thanks @Francesca-G! This is known and fixed in another PR #19679. I am moving PR to merge if there no other issues. |
|
I am not sure about this one. Probably not related to PR and can be fixed separately, WDYT @Parveshdhull?
|
|
Thank you @Francesca-G and @pavloburykh for testing the PR.
Yes this is known issue (Chat animation gets stuck mid way) and logged here #19639
This is also related to top-bar animation. If you checkout in the shared image, avatar is overlapping topbar because position of avatar is changed without changing its size etc. I think this one also should be fixed while addressing other top-bar issues. Will it be ok if I log this one with #19639 |
3 tasks
|
hi @pavloburykh, I logged the topbar overlap issue in #19639. Is PR ready for merging? |
Yes @Parveshdhull, ready for merge. Thank you! |
Parveshdhull
force-pushed
the
fix/community-channel
branch
from
58117e0 to
391d47d
Compare
…fter joining the community
Parveshdhull
force-pushed
the
fix/community-channel
branch
from
391d47d to
69c4cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19671
status: ready