Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI in the upper section of the chat differs from the lower section #19679

Merged
merged 1 commit into from
Apr 22, 2024
Merged

UI in the upper section of the chat differs from the lower section #19679

merged 1 commit into from
Apr 22, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Apr 16, 2024 •
edited
Loading

fixes #19633

Testing Notes:

PR fixes issue mentioned in #19633, while keeping the shadow as same as introduced in #19459 (comment)

While testing PR please compare shadow to the original PR instead of figma designs.

status: ready

@Parveshdhull Parveshdhull requested a review from ibrkhalil April 16, 2024 14:51
@Parveshdhull Parveshdhull self-assigned this Apr 16, 2024
@Parveshdhull Parveshdhull requested a review from jo-mut April 16, 2024 14:53
@status-im-auto
Copy link
Member

status-im-auto commented Apr 16, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (18)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 8c8ca72 #1 2024-04-16 14:54:54 ~2 min tests 📄log
✔️ 8c8ca72 #1 2024-04-16 14:59:25 ~7 min android-e2e 🤖apk 📲
✔️ 8c8ca72 #1 2024-04-16 14:59:29 ~7 min android 🤖apk 📲
✔️ 8c8ca72 #1 2024-04-16 15:03:03 ~10 min ios 📱ipa 📲
❌ 092d068 #2 2024-04-16 15:35:38 ~2 min tests 📄log
✔️ 092d068 #2 2024-04-16 15:39:49 ~7 min android 🤖apk 📲
✔️ 092d068 #2 2024-04-16 15:41:46 ~9 min android-e2e 🤖apk 📲
❌ e00e37b #3 2024-04-16 15:47:31 ~2 min tests 📄log
✔️ e00e37b #3 2024-04-16 15:50:58 ~6 min android-e2e 🤖apk 📲
✔️ e00e37b #3 2024-04-16 15:53:15 ~8 min android 🤖apk 📲
✔️ 0c28af5 #4 2024-04-16 15:59:48 ~4 min tests 📄log
✔️ 0c28af5 #4 2024-04-16 16:00:51 ~5 min android-e2e 🤖apk 📲
✔️ 0c28af5 #4 2024-04-16 16:01:16 ~6 min android 🤖apk 📲
✔️ 0c28af5 #4 2024-04-16 16:04:47 ~9 min ios 📱ipa 📲
❌ 738a3b5 #5 2024-04-22 14:16:27 ~2 min tests 📄log
✔️ 738a3b5 #5 2024-04-22 14:20:47 ~6 min android-e2e 🤖apk 📲
✔️ 738a3b5 #5 2024-04-22 14:22:29 ~8 min ios 📱ipa 📲
✔️ 738a3b5 #5 2024-04-22 14:22:29 ~8 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 5b3fd99 #6 2024-04-22 14:27:24 ~2 min tests 📄log
✔️ d32ed3a #8 2024-04-22 14:35:35 ~4 min tests 📄log
✔️ d32ed3a #8 2024-04-22 14:36:24 ~5 min android-e2e 🤖apk 📲
✔️ d32ed3a #8 2024-04-22 14:36:34 ~5 min android 🤖apk 📲
✔️ d32ed3a #8 2024-04-22 14:39:36 ~8 min ios 📱ipa 📲

ibrkhalil
ibrkhalil reviewed Apr 16, 2024
View reviewed changes
src/status_im/contexts/chat/messenger/messages/list/style.cljs Outdated
@@ -25,12 +24,10 @@
[bottom theme top-margin]
(reanimated/apply-animations-to-style
{:bottom bottom}
(merge
(shadows/get 2 (quo.theme/get-theme) :inverted)
Copy link
Contributor

@ibrkhalil ibrkhalil Apr 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the shadow at the top which was requested by @Francesca-G
CC: @VolodLytvynenko
#19459 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ibrkhalil for reviewing this PR.
Please can you check now, I moved this shadow to new container in background to avoid showing on top.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved the PR, But I think @Francesca-G is going to have a better eye in terms of reviewing the shadow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 52
Failed tests: 3
Expected to fail tests: 1
Passed tests: 48

IDs of failed tests: 727230,727229,702786 

IDs of expected to fail tests: 703503

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find `WalletTab` by `accessibility id`: `wallet-stack-tab` 

    critical/test_wallet.py:116: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:38: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:108: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:93: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:84: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:78: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:931: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Edited message is not shown correctly for the (receiver) admin



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (48)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    @pavloburykh pavloburykh mentioned this pull request Apr 17, 2024
    Merged
    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 18, 2024
    @VolodLytvynenko
    Copy link
    Contributor

    Hi @Parveshdhull no issues from my side.

    @Francesca-G Could you take a look, please?

    Francesca-G
    Francesca-G approved these changes Apr 22, 2024
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks fixed ✨

    @Parveshdhull Parveshdhull force-pushed the fix/chat-shadow branch 3 times, most recently from 5b3fd99 to b0fa40f Compare April 22, 2024 14:30
    @Parveshdhull Parveshdhull merged commit 96b09eb into develop Apr 22, 2024
    6 checks passed
    @Parveshdhull Parveshdhull deleted the fix/chat-shadow branch April 22, 2024 14:59
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    @jo-mut jo-mut jo-mut approved these changes

    Assignees

    @Parveshdhull Parveshdhull

    @VolodLytvynenko VolodLytvynenko

    Labels
    design-review-required request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    UI in the upper section of the chat differs from the lower section when light mode is enabled
    6 participants
    @Parveshdhull @status-im-auto @VolodLytvynenko @jo-mut @ibrkhalil @Francesca-G