Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add @stdlib/iter/do-while-each #808

Closed
3 tasks done
kgryte opened this issue Jan 31, 2023 · 4 comments · Fixed by #1704
Closed
3 tasks done

[RFC]: Add @stdlib/iter/do-while-each #808

kgryte opened this issue Jan 31, 2023 · 4 comments · Fixed by #1704
Assignees
@PraneGIT
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Jan 31, 2023

Description

This RFC proposes adding an iterator utility to invoke a function for each iterated value until a predicate function returns false.

This is the iterator equivalent of @stdlib/utils/do-while-each.

Package: @stdlib/iter/do-while-each
Alias: iterDoWhileEach

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Jan 31, 2023
@kgryte kgryte added priority: Low Low priority concern or feature request. Utilities Issue or pull request concerning general utilities. Accepted RFC feature request which has been accepted. JavaScript Issue involves or relates to JavaScript. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Feb 23, 2024
@Arnav2824
Copy link

@Planeshifter @kgryte I understood this issue, Please assign this to me

@kgryte
Copy link
Member Author

kgryte commented Feb 25, 2024

Thanks for volunteering to work on this, @Arnav2824. Please feel free to submit a PR implementing this feature.

@PraneGIT
Copy link
Contributor

PraneGIT commented Mar 4, 2024

@kgryte if this is still open can i work on this

@Planeshifter Planeshifter assigned PraneGIT and unassigned Arnav2824 Mar 4, 2024
@Planeshifter
Copy link
Member

Planeshifter commented Mar 4, 2024 •
edited
Loading

@PraneGIT Since I don't see any indication that Arnav2824 started working on this issue and it has been more than a week, I just unassigned him and assigned the issue to you. Feel free to submit a PR!

@PraneGIT PraneGIT mentioned this issue Mar 5, 2024
Merged
1 task
Planeshifter added a commit that referenced this issue Mar 8, 2024
@PraneGIT @Planeshifter
feat: add iter/do-while-each
3fabd41 
PR-URL: #1704
Closes: #808 

---------

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PraneGIT PraneGIT

Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add iter/do-while-each PraneGIT/stdlib
4 participants
@Planeshifter @kgryte @PraneGIT @Arnav2824