Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add iter/do-while-each #1704

Merged
merged 11 commits into from
Mar 8, 2024
Merged

feat: add iter/do-while-each #1704

merged 11 commits into from
Mar 8, 2024

Conversation

PraneGIT
Copy link
Contributor

@PraneGIT PraneGIT commented Mar 5, 2024

Resolves #808 .

Description

adds an iterator utility to invoke a function for each iterated value until a predicate function returns false.

This is the iterator equivalent of @stdlib/utils/do-while-each.

This pull request:

  • adds @stdlib/iter/do-while-each

Related Issues

Does this pull request have any related issues?

No.

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@PraneGIT
Copy link
Contributor Author

PraneGIT commented Mar 5, 2024

@Planeshifter can you review this PR ?

@Planeshifter Planeshifter self-requested a review March 5, 2024 15:10
@Planeshifter
Copy link
Member

@PraneGIT Will do today!

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. JavaScript Issue involves or relates to JavaScript. labels Mar 5, 2024
@Planeshifter Planeshifter changed the title feat: added @stdlib/iter/do-while-each feat: add iter/do-while-each Mar 6, 2024
@Planeshifter
Apply suggestions from code review
7e8a964 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/iter/do-while-each/README.md
24bb526 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/iter/do-while-each/package.json
b9fda9a 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/iter/do-while-each/README.md
c958a69 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/iter/do-while-each/README.md
7a4c63e 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/iter/do-while-each/README.md
568f85f 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/iter/do-while-each/lib/index.js
2019314 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 8, 2024
@Planeshifter Planeshifter merged commit 3fabd41 into stdlib-js:develop Mar 8, 2024
7 checks passed
@PraneGIT PraneGIT mentioned this pull request Mar 19, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
JavaScript Issue involves or relates to JavaScript. Ready To Merge A pull request which is ready to be merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/iter/do-while-each
2 participants
@PraneGIT @Planeshifter