Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kustomize API and Go version #15

Closed
wants to merge 2 commits into from

Conversation

lalloni
Copy link
Contributor

@lalloni lalloni commented Mar 4, 2021

Uses the latest Kustomize version and updates Go version.

@lalloni lalloni force-pushed the update-kustomize-api branch 2 times, most recently from 648e879 to d75fed3 Compare March 5, 2021 14:36
@lalloni lalloni changed the title Update Kustomize API version Update Kustomize API and Go version Mar 5, 2021
@stefanprodan
Copy link
Owner

@lalloni can you please rebase with upstream and force push

@lalloni lalloni force-pushed the update-kustomize-api branch from d75fed3 to d4417b1 Compare March 5, 2021 14:48
@stefanprodan
Copy link
Owner

@lalloni are you aware of fluxcd/flux2#918 ?

@lalloni
Copy link
Contributor Author

lalloni commented Mar 8, 2021

@stefanprodan I was partially aware (I'm using latest kustomize and needed to --enable_kyaml=false to avoid kyaml bugs, but wasn't hit by the go-getter issue).

In the case of kustomizer... what's the plan?

Somewhat related to this, I ended up using kustomizer as a post-processor replacing just kubectl-apply, after building the kustomization with kustomize proper, because otherwise it would break the build (because of #16), so it always receives a final plain k8s manifests yaml file, in which case this problem isn't significant.

@stefanprodan
Copy link
Owner

There is no --enable_kyaml in latest kustomize

@lalloni
Copy link
Contributor Author

lalloni commented Mar 8, 2021

Oh, I see... so I was confusing 3.9.x with 4.x...

@stefanprodan
Copy link
Owner

Closing this in favour of #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants