Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1: Reimplement reconciliation with server-side apply #17

Merged
merged 40 commits into from
Sep 7, 2021
Merged

v1: Reimplement reconciliation with server-side apply #17

merged 40 commits into from
Sep 7, 2021

Conversation

stefanprodan
Copy link
Owner

@stefanprodan stefanprodan commented Aug 30, 2021 •
edited
Loading

Changes:

  • implement reconciling and garbage collection with server-side apply
  • implement health checking with kstatus
  • drop kustomize and kubectl execs (kustomizer requires no other binary to be installed, only a valid kubeconfig)
  • add build command (compatible with Kustomize v4.3.0)
  • add diff command (masks Kubernetes Secrets values)
  • refactor apply command
  • refactor delete command
  • add tests using controller runtime envtest
  • refactor CI

The apply command performs the following actions:

  • decodes raw manifests and Kustomize overlays into Kubernetes objects
  • creates an inventory of objects to be applied (persisted on the cluster as a ConfigMap)
  • validates the objects with server-side dry-run apply
  • determines if the in-cluster objects are in drift based on the dry-run result
  • reconciles the objects on the cluster with server-side apply
  • waits for the objects to be fully reconciled by looking up their readiness status
  • prunes the objects that were previously applied but are missing from the current inventory
  • waits for the deleted objects to be terminated

Benchmark:

Operation Time Objects
kubectl dry-run 16.024s 110
kustomizer dry-run 15.258s 110
kubectl dry-run + apply 35.770s 110
kustomizer dry-run + apply 25.575s 110
kubectl delete 28.486s 110
kustomizer delete 21.507s 110

Benchmark conclusion:

Using kustomizer instead of kubectl for applying and deleting Kubernetes resources comes with no speed penalty.

@stefanprodan
Add server-side apply utilities (pkg/resmgr)
862a3b5 
The Resource Manager performs the following actions:
- decodes raw manifests (YAML & JSON) into Kubernetes objects
- validates the objects with server-side dry-run apply
- determines if the in-cluster objects are in drift based on the dry-run result
- reconciles the objects on the cluster with server-side apply
- waits for the objects to be fully reconciled by looking up their readiness status

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Refactor CI
5ce258f 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add filename validation
73cd092 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Refactor ResourceManager
3713811 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add inventory package
4d6a313 
The InventoryManager contains utilities for keeping a record of Kubernetes objects applied on a cluster.

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Implement garbage collection
bcc76fd 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add garbage collection e2e tests
107f1ab 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Implement deletion based on inventory
8566740 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add metadata to the inventory configmap
b031784 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Global inventory manager
de9193b 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Implement build command
cda56e7 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add e2e test for kustomize overlays pruning
1e970e6 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan changed the title v1: Implement server-side apply v1: Reimplement manifests reconciliation with server-side apply Aug 31, 2021
@stefanprodan
Apply mutating and validating webhooks last
67c386d 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Update controller-runtime to v0.10.0
97bcdc3 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add load test to CI
104e922 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Implement staged apply for CRDs+CRs
10c6940 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan force-pushed the v1-dev branch 3 times, most recently from ba753eb to 8b035d4 Compare September 1, 2021 15:24
@stefanprodan
Add staged apply e2e test (cert-manager)
8bc5df4 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Implement diff command
b0755c2 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Remove managed fields from diff output
80d675d 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan force-pushed the v1-dev branch 2 times, most recently from e632795 to 672c469 Compare September 2, 2021 08:46
@stefanprodan
Mask secrets in diff output
73ce16c 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Refactor resource manager apply tests
faf3464 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add diff tests
0951544 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add delete tests
e5583cf 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Run tests with race detection
cbfd86c 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Refactor package structure
9d50a5c 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add owner labels before apply
2ce8667 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan changed the title v1: Reimplement manifests reconciliation with server-side apply v1: Reimplement reconciliation with server-side apply Sep 3, 2021
@stefanprodan
Refactor inventory manager
d2edcb0 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add benchmark for apply
225df6e 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Use cli-utils/pkg/ordering
b7067df 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan force-pushed the v1-dev branch 2 times, most recently from a424501 to fdf1544 Compare September 6, 2021 08:20
@stefanprodan
Do apply in stages and fix replicas conflicts
ec3485e 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Update readme to v1
ddd10a7 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Update install instructions
e44c210 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan force-pushed the v1-dev branch 3 times, most recently from 08c76ba to ff7db62 Compare September 6, 2021 17:20
@stefanprodan
Implement get inventory command
a9348df 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
List inventories in tabular view
47a81fd 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan mentioned this pull request Sep 7, 2021
Closed
@stefanprodan stefanprodan marked this pull request as ready for review September 7, 2021 07:35
@stefanprodan stefanprodan merged commit 0e53c64 into main Sep 7, 2021
@stefanprodan stefanprodan deleted the v1-dev branch September 7, 2021 07:35
@JaneLiuL JaneLiuL mentioned this pull request Sep 14, 2021
Closed
@stefanprodan stefanprodan mentioned this pull request Oct 4, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stefanprodan