Skip to content

Commit

Permalink
txnbuild: remove superfluous signing key in challenge txn test (#2279)
Browse files Browse the repository at this point in the history
### What

Remove superfluous signing key in challenge transaction test that is used to sign the transaction twice when it only needs to sign the transaction once.

### Why

The key is added twice which was probably the result of a copy and paste from another tests where we test the behavior of signing a transaction twice. It's unnecessary to sign it twice here and having it sign the transaction twice is noise that is irrelevant to the scenario being tested in this test.
  • Loading branch information
leighmcculloch authored Feb 18, 2020
1 parent f958201 commit 579a156
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion txnbuild/transaction_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2293,7 +2293,7 @@ func TestVerifyChallengeTxSigners_invalidServerAndClientSignersFailsSignerSeed(t

err := tx.Build()
require.NoError(t, err)
err = tx.Sign(serverKP, clientKP2, clientKP2)
err = tx.Sign(serverKP, clientKP2)
assert.NoError(t, err)
tx64, err := tx.Base64()
require.NoError(t, err)
Expand Down

0 comments on commit 579a156

Please sign in to comment.