Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txnbuild: remove superfluous signing key in challenge txn test #2279

Merged
merged 1 commit into from
Feb 18, 2020
Merged

txnbuild: remove superfluous signing key in challenge txn test #2279

merged 1 commit into from
Feb 18, 2020

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Feb 15, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Remove superfluous signing key in challenge transaction test that is used to sign the transaction twice when it only needs to sign the transaction once.

Why

The key is added twice which was probably the result of a copy and paste from another tests where we test the behavior of signing a transaction twice. It's unnecessary to sign it twice here and having it sign the transaction twice is noise that is irrelevant to the scenario being tested in this test.

This was reported by @overcat: lightsail-network/java-stellar-sdk#264 (comment).

Known limitations

N/A

@leighmcculloch leighmcculloch merged commit 579a156 into stellar:master Feb 18, 2020
@leighmcculloch leighmcculloch deleted the txnbuild-make-test-clearer branch February 18, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants