Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts to all functions called from Tick() #3344

Closed
bartekn opened this issue Jan 14, 2021 · 2 comments · Fixed by #3567
Closed

Add timeouts to all functions called from Tick() #3344

bartekn opened this issue Jan 14, 2021 · 2 comments · Fixed by #3567
Assignees
@paulbellamy
Labels
bug horizon
Milestone
Horizon 2.2.0

Comments

@bartekn
Copy link
Contributor

bartekn commented Jan 14, 2021

What version are you using?

1.13.1

What did you do?

We don't set timeouts in functions in horizon.App.Tick() so if the connection gets stuck for any reason it will block entire Tick() method forever. It will affect metrics, fee stats and all the components of the system that rely on ingestion/ledger related stats.

Thanks @jacekn for reporting this!
@bartekn
Copy link
Contributor Author

bartekn commented Jan 14, 2021

Additionally check other places where this can cause issues.

@2opremio
Copy link
Contributor

Related #613

@ire-and-curses ire-and-curses added this to the Horizon 2.1.0 milestone Mar 3, 2021
@bartekn bartekn modified the milestones: Horizon 2.1.0, Horizon 2.2.0 Mar 31, 2021
@paulbellamy paulbellamy self-assigned this Apr 13, 2021
@paulbellamy paulbellamy mentioned this issue Apr 15, 2021
Merged
9 tasks
paulbellamy pushed a commit to paulbellamy/stellar-go that referenced this issue Apr 23, 2021
add 1s timeout to horizon.App.Tick
2826771 
Fixes stellar#3344
@paulbellamy paulbellamy mentioned this issue Apr 23, 2021
Merged
7 tasks
paulbellamy pushed a commit that referenced this issue Apr 26, 2021
services/horizon: Add 1s timeout to horizon.App.Tick (#3567)
2348575 
* add 1s timeout to horizon.App.Tick

Fixes #3344

* Increase tickerMaxDuration to 10s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulbellamy paulbellamy

Labels
bug horizon
Projects
None yet
Milestone
Horizon 2.2.0
Development

Successfully merging a pull request may close this issue.

services/horizon: Add 1s timeout to horizon.App.Tick paulbellamy/stellar-go
4 participants
@paulbellamy @bartekn @ire-and-curses @2opremio