Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elide tx-meta from transaction data model in db and api. #5189

Closed
sreuland opened this issue Jan 31, 2024 · 3 comments
Closed

Elide tx-meta from transaction data model in db and api. #5189

sreuland opened this issue Jan 31, 2024 · 3 comments
Assignees
@sreuland
Labels
performance issues aimed at improving performance rpc-sdk-scrum
Milestone
Soroban Pubnet Re...

Comments

@sreuland
Copy link
Contributor

sreuland commented Jan 31, 2024 •
edited
Loading

What problem does your feature solve?

What would you like to see?

A new Horizon configuration setting, DISABLE_TXMETA, which defaults to FALSE. When it's TRUE, horizon will no longer store serialized tx-meta xdr in the history database or show it on the transaction API model.

history_transactions table should have serialized base64 for an empty xdr.TransactionMetaV3{} in tx_meta, and for the API resource model emitted for Transaction for this row needs to show the same empty value representation for
result_meta_xdr

revert the recently added DISABLE_SOROBAN_INGEST, as it removed soroban related parsing from tx-meta for effects and asset balances, however, in hindsight those were not necessary and do not incur a performance overhead.

What alternatives are there?
@sreuland sreuland moved this from Backlog to Current Sprint in Platform Scrum Jan 31, 2024
@sreuland sreuland self-assigned this Jan 31, 2024
@sreuland
Copy link
Contributor Author

cc: @mollykarcher

@mollykarcher mollykarcher added the performance issues aimed at improving performance label Feb 1, 2024
@mollykarcher mollykarcher added this to the Soroban Pubnet Release milestone Feb 13, 2024
@sreuland
Copy link
Contributor Author

@mollykarcher , do we want to target this for 2.28.3?

@sreuland sreuland moved this from Current Sprint to In Progress in Platform Scrum Feb 14, 2024
sreuland added a commit to sreuland/go that referenced this issue Feb 14, 2024
@sreuland
stellar#5189: added optional SKIP_TXMETA parameter to not persist tx …
394fde1 
…meta in transaction model, removed DISABLE_SOROBAN_INGEST, use SKIP_META instead
sreuland added a commit to sreuland/go that referenced this issue Feb 14, 2024
@sreuland
stellar#5189: fixed unit test
9467cf8
sreuland added a commit to sreuland/go that referenced this issue Feb 14, 2024
@sreuland
stellar#5189: retain 2.28.0 changelog notes for DISABLE_SOROBAN_INGEST
6a45a52
@sreuland sreuland mentioned this issue Feb 14, 2024
Merged
7 tasks
@mollykarcher mollykarcher moved this from In Progress to Needs Review in Platform Scrum Feb 14, 2024
sreuland added a commit to sreuland/go that referenced this issue Feb 14, 2024
@sreuland
stellar#5189: added invalid tx meta version default for SKIP_TXMETA, …
6264a8c 
…review feedback
sreuland added a commit that referenced this issue Feb 14, 2024
@sreuland
/services/horizon/ingest: add SKIP_TXMETA (#5208)
0188e74 
* Revert "services/horizon: Add DISABLE_SOROBAN_INGEST flag to skip soroban ingestion processing (#5176)"

This reverts commit bfaf9e1.

* #5189: added optional SKIP_TXMETA parameter to not persist tx meta in transaction model, removed DISABLE_SOROBAN_INGEST, use SKIP_META instead
@sreuland
Copy link
Contributor Author

#5208 merged to 2.28.3 release branch, closing.

@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Feb 15, 2024
sreuland added a commit to sreuland/go that referenced this issue Feb 20, 2024
@sreuland
/services/horizon/ingest: add SKIP_TXMETA (stellar#5208)
cae5b85 
* Revert "services/horizon: Add DISABLE_SOROBAN_INGEST flag to skip soroban ingestion processing (stellar#5176)"

This reverts commit bfaf9e1.

* stellar#5189: added optional SKIP_TXMETA parameter to not persist tx meta in transaction model, removed DISABLE_SOROBAN_INGEST, use SKIP_META instead
@mollykarcher mollykarcher mentioned this issue Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreuland sreuland

Labels
performance issues aimed at improving performance rpc-sdk-scrum
Projects
Platform Scrum
Status: Done
Milestone
Soroban Pubnet Release
Development

No branches or pull requests
2 participants
@mollykarcher @sreuland