/services/horizon/ingest: add SKIP_TXMETA #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oban ingestion processing (stellar#5176)" This reverts commit bfaf9e1.
…meta in transaction model, removed DISABLE_SOROBAN_INGEST, use SKIP_META instead
tamirms
reviewed
Feb 14, 2024
tamirms
reviewed
Feb 14, 2024
Comment on lines
41
to
42
| // TODO, generate TxChangesAfter also | ||
| //assert.Greater(t, len(txMetaResult.MustV2().TxChangesAfter), 0) |
There was a problem hiding this comment.
do you know of any operations that would trigger TxChangesAfter, i tried several and FeeBumps, but only generated TxChangesBefore.
There was a problem hiding this comment.
I think soroban refunds can appear in TxChangesAfter:
but if this case is difficult to produce, I think you can just delete the commented out code
tamirms
reviewed
Feb 14, 2024
tamirms
reviewed
Feb 14, 2024
tamirms
approved these changes
Feb 14, 2024
sreuland
added a commit
to sreuland/go
that referenced
this pull request
Feb 20, 2024
* Revert "services/horizon: Add DISABLE_SOROBAN_INGEST flag to skip soroban ingestion processing (stellar#5176)" This reverts commit bfaf9e1. * stellar#5189: added optional SKIP_TXMETA parameter to not persist tx meta in transaction model, removed DISABLE_SOROBAN_INGEST, use SKIP_META instead
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Added new
SKIP_TXMETA. Defaults toFALSE. WhenTRUEthe transaction model for classic or soroban tx's won't have tx meta populated anymore, on database, history_transactions.tx_meta column will have serialized xdr that equates to empty for any protocol version, such as for protocol 20,xdr.TransactionMeta.V3,Operations,TxChangesAfter,TxChangesBeforewill be empty arrays andSorobanMetawill be nil and API responses with transaction model will have same empty/nil.Removed
DISABLE_SOROBAN_INGESTconfiguration parameter and it's cohort by reverting #5176, it did similar tx-meta removal but was limited to just soroban specific,SKIP_TXMETAparameter instead and removed parsing effects/ops aspects derived from tx-meta, which wasn't needed.Why
to prevent extended storage space needs on db.
Closes #5189
Known limitations