services/horizon: return null txmeta in api model when SKIP_TXMETA enabled #5228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
When SKIP_TXMETA is enabled the api resource model for
Transaction.result_meta_xdr
will be set to null.Why
Closes #5221
prior work for eliding tx meta on SKIP_TXMETA for context - #5208
Known limitations
this will require a new horizon patch release 2.28.4
this will require a new go client sdk releast 0.16.0
To provide nullability on
Transaction.result_meta_xdr
, had to make breaking change on Transaction resource model, this will require propagating the nullable aspect to other SDK's to handle potential null's.