services/horizon/internal: Add fee_charged and max_fee to /fee_stats endpoint #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
commented
Nov 21, 2019
| ht.Assert.Equal(200, result.MaxFee.P95, "p95") | ||
| ht.Assert.Equal(200, result.MaxFee.P99, "p99") | ||
|
|
||
| ht.Assert.Equal(50, result.FeeCharged.Min, "min") |
There was a problem hiding this comment.
@bartekn can fee_charged be lower than 50? If not, we probably should make an update on the fee_charged entries in this test scenario?
There was a problem hiding this comment.
Have you found an answer to the question? I think the code is outdated so can't check it out.
There was a problem hiding this comment.
@bartekn yes, after scrolling around I came to the conclusion that it's done based on the data we have in the DB, which is fine then.
abuiles
commented
Nov 21, 2019
|
oh, I just realized I forgot to add max, will do that first thing in the morning. |
abuiles
changed the title
tamirms
reviewed
Nov 21, 2019
tamirms
approved these changes
Nov 21, 2019
abuiles
force-pushed
the
new-fee-stats
branch
from
a163964
to
1c6f06a
Compare
bartekn
reviewed
Nov 25, 2019
abuiles
commented
Nov 26, 2019
| @@ -16,26 +17,35 @@ import ( | |||
|
|
|||
| var _ actions.JSONer = (*FeeStatsAction)(nil) | |||
|
|
|||
| // this struct is very similar to hProtocol.feeStats but drops the usage of int | |||
| // in favor of int64 | |||
| type feeStats struct { | |||
There was a problem hiding this comment.
this is a temporary workaround while we update hProtocol.FeeStats
|
@bartekn I addressed your comments, thanks! |
This was referenced Nov 28, 2019
Closed
This was referenced Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Display fees charged and max fee in /
fee_statsendpoint. Fixes #1372Why
We have a way now to display not only
max_feebut alsofee_chargeddata on the/fee_statsend-point. This PR adds info for both fields and at the same time schedules the old field for deprecation which had a confusing name as described #1372 (comment)Known limitations
[TODO or N/A]