Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/docs: Update /fee_stats with max_fee and fee_charged. #1991

Merged
merged 5 commits into from
Dec 2, 2019

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Dec 2, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update fee stats docs with changes from #1964. Fixes #1990.

Why

PR #1964 added new fields.

Known limitations

N/A

@abuiles abuiles requested a review from bartekn December 2, 2019 16:53
@cla-bot cla-bot bot added the cla: yes label Dec 2, 2019
Copy link
Member

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks good! I had a couple of suggestions to make some of the wording less ambiguous.

abuiles and others added 3 commits December 2, 2019 15:09
Co-Authored-By: Eric Saunders <ire-and-curses@users.noreply.github.com>
Co-Authored-By: Eric Saunders <ire-and-curses@users.noreply.github.com>
@abuiles abuiles merged commit 750fef4 into release-horizon-v0.24.0 Dec 2, 2019
@abuiles abuiles deleted the update-fee-stats-docs branch December 2, 2019 20:48
@abuiles abuiles mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants