Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/interal/actions: Drop db2/core dependency in path finding actions. #2675

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Jun 5, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

  • Drop db2/core dependency on path finding actions.
  • Simplify tests for path finding, removing dependency on pre-built scenario.
  • Add mock for paths.Finder

Why

We are in the process of removing Horizon's dependency on core's db. This PR removes such dependency on the path finding end-points and changes the tests to not depend on pre-built SQL scenarios.

This is part of the work to drop db2/core (#2643).

Known limitations

@cla-bot cla-bot bot added the cla: yes label Jun 5, 2020
@abuiles abuiles requested review from tamirms, bartekn and a team June 5, 2020 18:32
assertions := &Assertions{tt.Assert}
rh := inMemoryPathFindingClient(
finder := paths.MockFinder{}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of filling the database with order and build the graph for the test, I decided to go with a mock and test that the actions behave correctly with the given query parameters. We don't have to worry about the result since we already have unit test for orderbook.OrderBookGraph behavior.

@abuiles abuiles merged commit 954ddeb into stellar:master Jun 8, 2020
@abuiles abuiles deleted the remove-core-q-from-path-finding branch June 8, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants