Remove Set #979
Merged
Remove Set #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
approved these changes
Jun 15, 2023
This was referenced Aug 11, 2023
graydon
added a commit
that referenced
this pull request
Aug 22, 2023
Reflects stellar/rs-stellar-xdr#291 which reflects stellar/stellar-xdr#136 which addresses stellar/stellar-xdr#135 which resulted from #979 This will need updating when stellar/rs-stellar-xdr#291 merges, before it can merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the Set type.
Why
As part of #379 we are changing the interfaces of all our collection types. Set is a collection type that might be useful, but it is doc hidden right now, and not in use. There's no evidence yet we need it.
Instead of spending time rewriting its interface to match that of Vec and Map, we will remove it, and then bring it back when the time is right.
Close #379