Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec still contains Set #135

Closed
graydon opened this issue Aug 11, 2023 · 2 comments
Closed

Spec still contains Set #135

graydon opened this issue Aug 11, 2023 · 2 comments
Assignees
@graydon

Comments

@graydon
Copy link
Contributor

graydon commented Aug 11, 2023

stellar-xdr/Stellar-contract-spec.x

Line 42 in 1894f09

SC_SPEC_TYPE_SET = 1003,

The Set type was removed from the SDK as unused a while back. I think we should probably also remove the spec type for it? I can't imagine it works right.
This was referenced Aug 11, 2023
Merged
Merged
Merged
graydon added a commit to stellar/rs-soroban-sdk that referenced this issue Aug 22, 2023
@graydon
Remove ScSpecTypeSet support, which was already mostly dead. (#1054)
ff71e74 
Reflects stellar/rs-stellar-xdr#291 which
reflects stellar/stellar-xdr#136 which addresses
stellar/stellar-xdr#135 which resulted from
#979

This will need updating when
stellar/rs-stellar-xdr#291 merges, before it can
merge.
@graydon
Copy link
Contributor Author

graydon commented Aug 25, 2023

this is mostly done. there's just one remaining update to land in tools (already written, just pending core build availability): stellar/stellar-cli#884

@graydon
Copy link
Contributor Author

graydon commented Sep 5, 2023

This is now complete.

@graydon graydon closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graydon graydon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@graydon