Update to remove ScSpecTypeSet #884
Conversation
|
You probably want to avoid merging this though until the new core build is in, otherwise the CI will break again. Right? |
2opremio
force-pushed
the
remove-set-from-spec
branch
from
62ede7b to
ef46129
Compare
| @@ -54,7 +50,8 @@ pub(crate) fn compute_host_function_transaction_data_and_min_fee( | |||
| &soroban_resources.footprint, | |||
| ) | |||
| .context("cannot estimate maximum transaction size")?, | |||
| contract_events_size_bytes: soroban_resources.contract_events_size_bytes, | |||
| contract_events_size_bytes: calculate_event_size_bytes(events) | |||
There was a problem hiding this comment.
Not related to the current failures, but you should calculate the size of the contract events only, not all the diagnostic events (i.e. you need to filter based on the event type in that function).
2opremio
force-pushed
the
remove-set-from-spec
branch
from
4a66d76 to
b559d80
Compare
2opremio
force-pushed
the
remove-set-from-spec
branch
2 times, most recently
from
71df30d to
307681c
Compare
|
OK, the soroban-rpc integration tests finally work but I can't merge this until stellar/rs-stellar-xdr#291 (comment) is resolved (which is causing the other CI issues) |
2opremio
force-pushed
the
remove-set-from-spec
branch
from
307681c to
c463ba0
Compare
2opremio
force-pushed
the
remove-set-from-spec
branch
from
dde8f7d to
0f70972
Compare
2opremio
force-pushed
the
remove-set-from-spec
branch
from
0f70972 to
0eb1837
Compare
|
@sreuland note that this PR caused an update in the XDR, making the javascript client temporarily incompatible and impacting your system test fixes. |
thanks, will merge main into #855 and continue to see how far e2e gets on latest, have been working through cli/rpc/preflight interop. do you think this is the last xdr updates, this looks great, as it has updated ver refs of everything in here, go, rs-sdk, rs-env, and core build. |
|
Unfortunately there will be more XDR changes (the state expiration ones) |
Second attempt at #857 , which was reverted due to breaking CI
Parent issue : #872