Update the examples for protocol 22 support. #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
force-pushed
the
p22_fixes
branch
7 times, most recently
from
5b2d970 to
be39170
Compare
Most of the updates involve using constructors and the new test API. I've also addressed a couple small issues in some examples.
|
I'm going to merge #327 first, before this PR merges as it addresses a few issues for existing v21 examples, then let's rebase this PR and target a merge. |
Sure, this PR shouldn't be merged until 22 is live anyway. |
chadoh
added a commit
to AhaLabs/soroban-examples
that referenced
this pull request
Nov 27, 2024
Fixes stellar#328 Undoes stellar#232 Forked from stellar#330 Add top-level `Cargo.toml`, with all project folders as part of this workspace. We now encourage everyone to use Cargo workspaces when building Soroban projects. Let's make it easy to copy-paste these examples into their projects, rather than requiring special tooling (like the old `stellar contract init` behavior) to update the contract's Cargo.toml. Currently, there are two compilation errors when attempting to run tests: ``` error[E0433]: failed to resolve: use of undeclared crate or module `__get_allowance` --> token/src/contract.rs:67:12 | 67 | pub fn get_allowance(e: Env, from: Address, spender: Address) -> Option<AllowanceValue> { | ^^^^^^^^^^^^^ use of undeclared crate or module `__get_allowance` | help: there is a crate or module with a similar name | 67 | pub fn __allowance(e: Env, from: Address, spender: Address) -> Option<AllowanceValue> { | ~~~~~~~~~~~ error[E0223]: ambiguous associated type --> bls_signature/src/lib.rs:78:18 | 78 | agg_sig: Self::Signature, | ^^^^^^^^^^^^^^^ help: use fully-qualified syntax: `<IncrementContractArgs as soroban_sdk::testutils::ed25519::Sign>::Signature` ```
This was referenced Nov 27, 2024
chadoh
added a commit
to AhaLabs/soroban-examples
that referenced
this pull request
Nov 27, 2024
Fixes stellar#328 Undoes stellar#232 Forked from stellar#330 Add top-level `Cargo.toml`, with all project folders as part of this workspace. We now encourage everyone to use Cargo workspaces when building Soroban projects. Let's make it easy to copy-paste these examples into their projects, rather than requiring special tooling (like the old `stellar contract init` behavior) to update the contract's Cargo.toml. Currently, there are two compilation errors when attempting to run tests: ``` error[E0433]: failed to resolve: use of undeclared crate or module `__get_allowance` --> token/src/contract.rs:67:12 | 67 | pub fn get_allowance(e: Env, from: Address, spender: Address) -> Option<AllowanceValue> { | ^^^^^^^^^^^^^ use of undeclared crate or module `__get_allowance` | help: there is a crate or module with a similar name | 67 | pub fn __allowance(e: Env, from: Address, spender: Address) -> Option<AllowanceValue> { | ~~~~~~~~~~~ ```
sisuresh
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the examples for protocol 22 support.
Most of the updates involve using constructors and the new test API. I've also addressed a couple small issues in some examples.
Why
Keeping the examples up to date
Known limitations
This shouldn't be merged until protocol 22 has been voted on in pubnet.