feat: structure as cargo workspace #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the updates involve using constructors and the new test API. I've also addressed a couple small issues in some examples.
Fixes stellar#328 Undoes stellar#232 Forked from stellar#330 Add top-level `Cargo.toml`, with all project folders as part of this workspace. We now encourage everyone to use Cargo workspaces when building Soroban projects. Let's make it easy to copy-paste these examples into their projects, rather than requiring special tooling (like the old `stellar contract init` behavior) to update the contract's Cargo.toml. Currently, there are two compilation errors when attempting to run tests: ``` error[E0433]: failed to resolve: use of undeclared crate or module `__get_allowance` --> token/src/contract.rs:67:12 | 67 | pub fn get_allowance(e: Env, from: Address, spender: Address) -> Option<AllowanceValue> { | ^^^^^^^^^^^^^ use of undeclared crate or module `__get_allowance` | help: there is a crate or module with a similar name | 67 | pub fn __allowance(e: Env, from: Address, spender: Address) -> Option<AllowanceValue> { | ~~~~~~~~~~~ ```
chadoh
force-pushed
the
feat/cargo-workspace
branch
from
6735a95 to
5c6a2b9
Compare
Closed
|
As discussed in #328, we have decided not to implement this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
Undoes #232
Forked from #330
mainonce it's mergedWhat
Add top-level
Cargo.toml, with all project folders as part of thisworkspace.
Why
We now encourage everyone to use Cargo workspaces when building Soroban
projects. Let's make it easy to copy-paste these examples into their
projects, rather than requiring special tooling
(like the old
stellar contract initbehavior) to update the contract'sCargo.toml.
Known Limitations
Currently, there is a compilation error when attempting to run tests: