Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Storage to XDR file #21

Closed
leighmcculloch opened this issue Jul 6, 2022 · 2 comments · Fixed by #24
Closed

CLI: Storage to XDR file #21

leighmcculloch opened this issue Jul 6, 2022 · 2 comments · Fixed by #24
Assignees
@sisuresh

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Jul 6, 2022 •
edited
Loading

Invoke contract with persistent storage/ledgerstate
@leighmcculloch leighmcculloch changed the title Invoke contract with persistent storage Invoke contract with persistent storage/ledgerstate Jul 6, 2022
@leighmcculloch leighmcculloch changed the title Invoke contract with persistent storage/ledgerstate CLI: Storage Jul 6, 2022
@leighmcculloch
Copy link
Member Author

The format of the storage is sufficient as XDR for now, but there would be benefits to this being JSON or TxRep in the future. These issues exist for future work to support those types: stellar/xdrgen#112 stellar/xdrgen#113.

@leighmcculloch
Copy link
Member Author

Since the format is XDR, I added another issue for a subcommand to decode it if needed, which we can trivially add at some point: #23

@leighmcculloch leighmcculloch linked a pull request Jul 8, 2022 that will close this issue
Read and write xdr to file for persistent storage #24
Merged
@leighmcculloch leighmcculloch changed the title CLI: Storage CLI: Storage to XDR file Jul 12, 2022
willemneal added a commit that referenced this issue Feb 6, 2024
@willemneal
[Epic] Separating soroban-rpc to prepare for repo change (#1174)
2581f62 
* feat: move ContractSpec to spec tools crate

* feat: add methods to GetTransaction and break up sending transaction

* feat: make persistent the default storage type

* feat: create soroban-rpc crate (#21)

* feat: create soroban-rpc crate

* fix: add event test

* fix: switch to --is-view so e2e tests will pass and no breaking changes
psheth9 pushed a commit that referenced this issue Feb 7, 2024
@willemneal @psheth9
[Epic] Separating soroban-rpc to prepare for repo change (#1174)
ed308cc 
* feat: move ContractSpec to spec tools crate

* feat: add methods to GetTransaction and break up sending transaction

* feat: make persistent the default storage type

* feat: create soroban-rpc crate (#21)

* feat: create soroban-rpc crate

* fix: add event test

* fix: switch to --is-view so e2e tests will pass and no breaking changes
psheth9 pushed a commit that referenced this issue Feb 7, 2024
@willemneal @psheth9
[Epic] Separating soroban-rpc to prepare for repo change (#1174)
51d85ee 
* feat: move ContractSpec to spec tools crate

* feat: add methods to GetTransaction and break up sending transaction

* feat: make persistent the default storage type

* feat: create soroban-rpc crate (#21)

* feat: create soroban-rpc crate

* fix: add event test

* fix: switch to --is-view so e2e tests will pass and no breaking changes
psheth9 pushed a commit that referenced this issue Feb 7, 2024
@willemneal @psheth9
Rebase
11abb44 
[Epic] Separating soroban-rpc to prepare for repo change (#1174)

* feat: move ContractSpec to spec tools crate

* feat: add methods to GetTransaction and break up sending transaction

* feat: make persistent the default storage type

* feat: create soroban-rpc crate (#21)

* feat: create soroban-rpc crate

* fix: add event test

* fix: switch to --is-view so e2e tests will pass and no breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sisuresh sisuresh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read and write xdr to file for persistent storage sisuresh/stellar-contract-cli
2 participants
@leighmcculloch @sisuresh