[Epic] Separating soroban-rpc to prepare for repo change #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
force-pushed
the
feat/sperate_rpc
branch
3 times, most recently
from
ebc1aa3
to
78a019a
Compare
willemneal
force-pushed
the
feat/sperate_rpc
branch
2 times, most recently
from
070c80f
to
d1e5709
Compare
|
Currently the rust is failing when building windows because the rust version is 1.70.0, but soroban-sdk requires 1.74.0. e2e tests are still failing because of the changes introduced by this PR. Currently it relies on the fact that previously all invokes where signed and submitted, regardless if they had auth and had no writes. I added a flag with an env var to get around this. I had hoped that I added to the RPC tests to test the same case that is failing for e2e tests and those are passing. Should I make a branch of the e2e? Or should I make signed the default so that this isn't a breaking change? |
willemneal
force-pushed
the
feat/sperate_rpc
branch
2 times, most recently
from
4ef52d0
to
78888b2
Compare
willemneal
force-pushed
the
feat/sperate_rpc
branch
2 times, most recently
from
908ffa8
to
25774c4
Compare
willemneal
force-pushed
the
feat/sperate_rpc
branch
from
25774c4
to
9b1e0be
Compare
stellarsaur
approved these changes
Feb 5, 2024
* feat: create soroban-rpc crate * chore: add doc strings
SYSTEM_TEST_VERBOSE_OUTPUT was added to get system tests to pass this
willemneal
force-pushed
the
feat/sperate_rpc
branch
from
9b1e0be
to
3bf8baf
Compare
willemneal
force-pushed
the
feat/sperate_rpc
branch
2 times, most recently
from
833d482
to
74e962e
Compare
willemneal
force-pushed
the
feat/sperate_rpc
branch
from
74e962e
to
9ee03a5
Compare
|
I am going to (temporarilly) revert this PR since it's breaking the release 20.3.0 ( #1190 ) and it's urgent. We can reapply it later We should also come up with a better release process (resilient towards interim changes to |
2opremio
added a commit
that referenced
this pull request
Feb 6, 2024
…)" This reverts commit 2581f62.
2opremio
added a commit
that referenced
this pull request
Feb 6, 2024
psheth9
pushed a commit
that referenced
this pull request
Feb 7, 2024
* feat: move ContractSpec to spec tools crate * feat: add methods to GetTransaction and break up sending transaction * feat: make persistent the default storage type * feat: create soroban-rpc crate (#21) * feat: create soroban-rpc crate * fix: add event test * fix: switch to --is-view so e2e tests will pass and no breaking changes
psheth9
pushed a commit
that referenced
this pull request
Feb 7, 2024
psheth9
pushed a commit
that referenced
this pull request
Feb 7, 2024
* feat: move ContractSpec to spec tools crate * feat: add methods to GetTransaction and break up sending transaction * feat: make persistent the default storage type * feat: create soroban-rpc crate (#21) * feat: create soroban-rpc crate * fix: add event test * fix: switch to --is-view so e2e tests will pass and no breaking changes
psheth9
pushed a commit
that referenced
this pull request
Feb 7, 2024
psheth9
pushed a commit
that referenced
this pull request
Feb 7, 2024
[Epic] Separating soroban-rpc to prepare for repo change (#1174) * feat: move ContractSpec to spec tools crate * feat: add methods to GetTransaction and break up sending transaction * feat: make persistent the default storage type * feat: create soroban-rpc crate (#21) * feat: create soroban-rpc crate * fix: add event test * fix: switch to --is-view so e2e tests will pass and no breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use testcontainers to test CLI instead of through go.In follow up PRWhy
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]