soroban-rpc: Consider enforcing Diagnostic Events in captive core #806
Comments
|
I think that, in order to offer users a way out, we should pass on |
2opremio
added a commit
to 2opremio/go-2
that referenced
this issue
Jul 27, 2023
…aptive core backend The configuration parameter (`EnforceSorobanDiagnosticEvents`)is optional and makes sure `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS` is set to true for captive core unless the user explicitly sets `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=false` in the appendix file. This fixes stellar/stellar-cli#806 (when `EnforceSorobanDiagnosticEvents` is set to true)
2opremio
added a commit
to 2opremio/go-2
that referenced
this issue
Jul 27, 2023
…aptive core backend The configuration parameter (`EnforceSorobanDiagnosticEvents`)is optional and makes sure `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS` is set to true for captive core unless the user explicitly sets `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=false` in the appendix file. This fixes stellar/stellar-cli#806 (when `EnforceSorobanDiagnosticEvents` is set to true)
2opremio
added a commit
to 2opremio/go-2
that referenced
this issue
Jul 28, 2023
…aptive core backend The configuration parameter (`EnforceSorobanDiagnosticEvents`)is optional and makes sure `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS` is set to true for captive core unless the user explicitly sets `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=false` in the appendix file. This fixes stellar/stellar-cli#806 (when `EnforceSorobanDiagnosticEvents` is set to true)
2opremio
added a commit
to 2opremio/go-2
that referenced
this issue
Jul 28, 2023
…aptive core backend The configuration parameter (`EnforceSorobanDiagnosticEvents`)is optional and makes sure `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS` is set to true for captive core unless the user explicitly sets `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=false` in the appendix file. This fixes stellar/stellar-cli#806 (when `EnforceSorobanDiagnosticEvents` is set to true)
2opremio
added a commit
to 2opremio/go-2
that referenced
this issue
Jul 29, 2023
…aptive core backend The configuration parameter (`EnforceSorobanDiagnosticEvents`)is optional and makes sure `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS` is set to true for captive core unless the user explicitly sets `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=false` in the appendix file. This fixes stellar/stellar-cli#806 (when `EnforceSorobanDiagnosticEvents` is set to true)
2opremio
added a commit
to stellar/go
that referenced
this issue
Jul 29, 2023
…aptive core backend (#4985) The configuration parameter (`EnforceSorobanDiagnosticEvents`)is optional and makes sure `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS` is set to true for captive core unless the user explicitly sets `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=false` in the appendix file. This fixes stellar/stellar-cli#806 (when `EnforceSorobanDiagnosticEvents` is set to true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now it's up to the end user to enable Diagnostic events in soroban-rpc's captive core instance.
In order to enable them then need to add
ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=trueto the captive core configuration file passed through--captive-core-config-path.We should consider enforcing
ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=truein the final configuration file passed to captive core (which is already mixture of the configuration in--captive-core-config-pathand baked in options).This will require changing
generateConfigFile()at https://github.com/stellar/go/blob/master/ingest/ledgerbackend/stellar_core_runner.go#L158The text was updated successfully, but these errors were encountered: