soroban-rpc: Enforce enabling diagnostics events #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
enforce-diagnostic-events
branch
from
04ccd7b
to
29ccbf7
Compare
2opremio
force-pushed
the
enforce-diagnostic-events
branch
from
29ccbf7
to
0f9e553
Compare
tamirms
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #806 by making use of stellar/go#4985
This PR sets
ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=truein the generated config file of soroban-rpc's captive core unless the user explicitly opposes to (by settingENABLE_SOROBAN_DIAGNOSTIC_EVENTS=falsein the appendix file passed though--captive-core-config-path)