Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update network container start command to use updated enable flags #1371

Merged

Conversation

elizabethengelman
Copy link
Contributor

@elizabethengelman elizabethengelman commented Jun 11, 2024

What

  • Update the enable flag that is passed to the quickstart container.
  • Default the local network to use the testing quickstart image tag instead of latest

Why

  • There was a change made to the quickstart container to allow for optionally starting up services, and this change takes advantage of that to only start up the rpc service and horizon by default.

Known limitations

N/A

@elizabethengelman elizabethengelman marked this pull request as ready for review June 12, 2024 13:18
@elizabethengelman
Copy link
Contributor Author

@leighmcculloch related to this change, the dockerhub description for quickstart is a bit out-of-date, and doesn't include info about the --enable rpc,horizon flag, etc. I wonder if we could update that description to be a link to the repo's README instead, so we don't have to worry about updating the description in two places.

Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And I like the idea of making the Dockerhub readme a link to the main README. @leighmcculloch do you also like @elizabethengelman's suggestion?

@leighmcculloch
Copy link
Member

leighmcculloch commented Jun 13, 2024

Interesting. The dockerhub description used to update automatically, something must have broken with the linking. We can use a github action to update the readme on each publish, but I think linking to the GitHub repo would also be simpler. I'll open a ticket with the team who can action updating the dockerhub readme manually to link to the github one.

@elizabethengelman elizabethengelman enabled auto-merge (squash) June 14, 2024 13:09
@elizabethengelman elizabethengelman merged commit 5925d55 into stellar:main Jun 14, 2024
24 checks passed
@elizabethengelman elizabethengelman deleted the fix/update-quickstart-start-command branch June 14, 2024 13:42
@elizabethengelman
Copy link
Contributor Author

elizabethengelman commented Jun 18, 2024

closes #1365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update the docker command being run in network container start
3 participants