Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update network container start command to use updated enable flags #1371

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Fix/update network container start command to use updated enable flags #1371

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03e2d85
Update network container start to use --enable rpc,horizon instead of…
elizabethengelman Jun 11, 2024
9313892
Update network container start to use testing quickstart tag for local
elizabethengelman Jun 11, 2024
eceb7c7
Merge branch 'main' into fix/update-quickstart-start-command
elizabethengelman Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/soroban-cli/src/commands/network/container/start.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ async fn run_docker_command(cmd: &Cmd) -> Result<(), Error> {
fn get_container_args(cmd: &Cmd) -> Vec<String> {
[
format!("--{}", cmd.network),
"--enable-soroban-rpc".to_string(),
"--enable rpc,horizon".to_string(),
get_protocol_version_arg(cmd),
get_limits_arg(cmd),
]
Expand All @@ -135,9 +135,9 @@ fn get_container_args(cmd: &Cmd) -> Vec<String> {
fn get_image_name(cmd: &Cmd) -> String {
// this can be overriden with the `-t` flag
let mut image_tag = match cmd.network {
Network::Testnet => "testing",
Network::Pubnet => "latest",
Network::Futurenet => "future",
_ => "latest", // default to latest for local and pubnet
_ => "testing", // default to testing for local and testnet
elizabethengelman marked this conversation as resolved.
Show resolved Hide resolved
};

if let Some(image_override) = &cmd.image_tag_override {
Expand Down
Loading