Update CLI and soroban-rpc to the latest XDR changes #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
requested review from
paulbellamy,
willemneal,
sisuresh,
tsachiherman and
dmkozh
2opremio
commented
Aug 7, 2023
2opremio
commented
Aug 7, 2023
2opremio
commented
Aug 7, 2023
2opremio
commented
Aug 7, 2023
2opremio
commented
Aug 7, 2023
2opremio
commented
Aug 7, 2023
2opremio
commented
Aug 8, 2023
|
Should this PR target main? Shouldn't main stay in line with futurenet's XDR? |
dmkozh
reviewed
Aug 8, 2023
I believe that it's already not aligned with futurenet, but rather an intermediate xdr. |
Main already contains XDR changes ahead of futurenet. The futurenet code was tagged at https://github.com/stellar/soroban-tools/tree/v0.9.5 |
|
Ah cool good to know! So we can't release the CLI again until futurenet is aligned? |
Shaptic
reviewed
Aug 8, 2023
|
@willemneal we could branch off of v0.9.5 and cherry-pick, but I don't know if our CI/CD supports publishing crates with that workflow? |
paulbellamy
reviewed
Aug 9, 2023
tamirms
approved these changes
Aug 10, 2023
paulbellamy
pushed a commit
that referenced
this pull request
Aug 18, 2023
paulbellamy
pushed a commit
that referenced
this pull request
Aug 18, 2023
paulbellamy
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Fix ledgerentry visibility bug from #846 * Fix test output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update CLI and soroban-rpc to the latest XDR changes
Why
Fixes part of #844
Known limitations
N/A