Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: Fix upstert bug in DB cache #847

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Aug 7, 2023

Leftover from #837

BTW, the fact that the system tests are failing all the time gets the eye used to seeing red-crosses in CI. This lets problems like this leak through the cracks.

We should probably make the unit tests mandatory for merging although I would prefer for the system tests not to be broken so often (CC @tsachiherman @sreuland )

@2opremio 2opremio requested a review from tamirms August 7, 2023 22:40
@2opremio 2opremio changed the title soroban-rpc: Fix deletion bug in DB cache soroban-rpc: Fix upstert bug in DB cache Aug 7, 2023
@sreuland
Copy link
Contributor

sreuland commented Aug 7, 2023

ok, can take a look at e2e tomorrow, in the ci output, the rpc ingestion is logging xdr parse errors, maybe we need to bump the go pkg ref, cor core version, etc.

time="2023-08-07T23:07:02.178Z" level=error msg="could not run ingestion. Retrying" error="Error while reading from buckets: Error on XDR record -1 of hash '74585b1a9372de0e01a48318f5734290975fb9381a0990c4fa1128ab132a6d78': decoding LedgerEntry: decoding LedgerEntryExt: decoding LedgerEntryExtensionV1: decoding SponsorshipDescriptor: decoding PublicKey: decoding Uint256: decoding Uint256: xdr:DecodeFixedOpaqueInplace: EOF while decoding 32 bytes - read: '[]'" pid=271

@tsachiherman
Copy link
Contributor

ok, can take a look at e2e tomorrow, in the ci output, the rpc ingestion is logging xdr parse errors, maybe we need to bump the go pkg ref, cor core version, etc.

time="2023-08-07T23:07:02.178Z" level=error msg="could not run ingestion. Retrying" error="Error while reading from buckets: Error on XDR record -1 of hash '74585b1a9372de0e01a48318f5734290975fb9381a0990c4fa1128ab132a6d78': decoding LedgerEntry: decoding LedgerEntryExt: decoding LedgerEntryExtensionV1: decoding SponsorshipDescriptor: decoding PublicKey: decoding Uint256: decoding Uint256: xdr:DecodeFixedOpaqueInplace: EOF while decoding 32 bytes - read: '[]'" pid=271

I'd suspect that the js soroban client version doesn't point to a hash that matches the latest xdr.

@2opremio 2opremio merged commit 0fba915 into stellar:main Aug 8, 2023
@2opremio 2opremio deleted the fix-cache-upserts branch August 8, 2023 00:20
@2opremio
Copy link
Contributor Author

2opremio commented Aug 8, 2023

ok, can take a look at e2e tomorrow, in the ci output, the rpc ingestion is logging xdr parse errors, maybe we need to bump the go pkg ref, cor core version, etc.

Yeah, see #846

kalepail pushed a commit to kalepail/soroban-tools that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants