Run desired unit tests instead of only Mac. #459
Conversation
|
I can't see anything helpful in the logs about why that one job failed. I'm hoping it was just a spurious failure, so I'll close and reopen to retrigger the tests. |
|
Yep, looks like it passed. Weird. |
| @@ -1,6 +1,9 @@ | |||
| BUILD_TOOL = xcodebuild | |||
| BUILD_SCHEME = SQLite Mac | |||
There was a problem hiding this comment.
I think it would be useful to leave this default in so that (fast) tests can be run from the command line with a simple make or make test, instead of a lengthy make test BUILD_SCHEME='SQLite Mac'.
There was a problem hiding this comment.
It wasn't a default, it was just ignoring whatever you passed in and always using SQLite Mac for the scheme.
But yes, I agree that having a default to make it easier to run quick tests from the command line would be a good change to make.
There was a problem hiding this comment.
I think it would need to be wrapped in an if [ -z "$BUILD_SCHEME" ] to make it act like a default instead of an override.
There was a problem hiding this comment.
it should work via make's conditional =? operator (or ?=, can't remember the order)
Il giorno 8 luglio 2016 @ 16:16:27, Nick Shelley (notifications@github.com(mailto:notifications@github.com)) ha scritto:
In Makefile(#459 (comment)):
@@ -1,6 +1,9 @@ > BUILD_TOOL = xcodebuild > -BUILD_SCHEME = SQLite Mac
I think it would need to be wrapped in an if [ -z "$BUILD_SCHEME" ] to make it act like a default instead of an override.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub(https://github.com/stephencelis/SQLite.swift/pull/459/files/6759aad915b5bfc39f9b6f733785690ab69ef5e0#r70080494), or mute the thread(https://github.com/notifications/unsubscribe/AABJyzkQU3_BUhfRAX1DkGS6KYFU6mHCks5qTlu7gaJpZM4I9PdX).
If you look at the logs of any of the previous travis builds, they all run Mac tests, even when the scheme is set to "SQLite iOS". This should fix that.