Skip to content

Run desired unit tests instead of only Mac. #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Run desired unit tests instead of only Mac. #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
BUILD_TOOL = xcodebuild
BUILD_SCHEME = SQLite Mac
BUILD_ARGUMENTS = -scheme "$(BUILD_SCHEME)"
ifeq ($(BUILD_SCHEME),SQLite iOS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be useful to leave this default in so that (fast) tests can be run from the command line with a simple make or make test, instead of a lengthy make test BUILD_SCHEME='SQLite Mac'.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't a default, it was just ignoring whatever you passed in and always using SQLite Mac for the scheme.

But yes, I agree that having a default to make it easier to run quick tests from the command line would be a good change to make.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would need to be wrapped in an if [ -z "$BUILD_SCHEME" ] to make it act like a default instead of an override.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should work via make's conditional =? operator (or ?=, can't remember the order)

Il giorno 8 luglio 2016 @ 16:16:27, Nick Shelley (notifications@github.com(mailto:notifications@github.com)) ha scritto:

In Makefile(#459 (comment)):

@@ -1,6 +1,9 @@ > BUILD_TOOL = xcodebuild > -BUILD_SCHEME = SQLite Mac

I think it would need to be wrapped in an if [ -z "$BUILD_SCHEME" ] to make it act like a default instead of an override.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub(https://github.com/stephencelis/SQLite.swift/pull/459/files/6759aad915b5bfc39f9b6f733785690ab69ef5e0#r70080494), or mute the thread(https://github.com/notifications/unsubscribe/AABJyzkQU3_BUhfRAX1DkGS6KYFU6mHCks5qTlu7gaJpZM4I9PdX).

BUILD_ARGUMENTS = -scheme "$(BUILD_SCHEME)" -sdk iphonesimulator
else
BUILD_ARGUMENTS = -scheme "$(BUILD_SCHEME)"
endif

XCPRETTY := $(shell command -v xcpretty)
SWIFTCOV := $(shell command -v swiftcov)
Expand Down