Skip to content

Xcode8 #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Xcode8 #475

wants to merge 13 commits into from

Conversation

jberkel
Copy link
Collaborator

@jberkel jberkel commented Jul 22, 2016

No description provided.

@jberkel jberkel mentioned this pull request Jul 22, 2016
Closed
@stephencelis
Copy link
Owner

Given GM release, do you suppose Travis is up to the task yet?

@jberkel
Copy link
Collaborator Author

jberkel commented Sep 13, 2016

hope so, i'll give it a go

@stephencelis
Copy link
Owner

Thanks so much for your regular contributions, @jberkel! Always great stuff.

@jberkel
Copy link
Collaborator Author

jberkel commented Sep 13, 2016

glad to be able to help. the pod integration tests run fine locally now but stall on travis. not quite sure what's going on, investigating...

@jberkel jberkel mentioned this pull request Sep 14, 2016
Closed
@jberkel jberkel changed the title [WIP] Xcode8 Xcode8 Sep 15, 2016
@jberkel
Copy link
Collaborator Author

jberkel commented Sep 15, 2016 •
edited
Loading

Would be great if somebody could sanity check these changes. The tests run now on Xcode 7 and 8. However there are currently intermittent failures on Xcode 8, this is a known problem, see travis-ci/travis-ci#6422 for a discussion.

Let's hope that things will get more stable with coming updates.

This was referenced Sep 17, 2016
Merged
Closed
@mbarclay
Copy link

Hi @jberkel. The xcode8 branch is working well for me using Carthage, Xcode 8, Swift 2.8. Are you aware of the sqlite3_trace deprecation warning? Superseded by sqlite3_trace_v2.

@jberkel
Copy link
Collaborator Author

jberkel commented Sep 30, 2016 •
edited
Loading

@mbarclay i've noticed the warning, no need to worry. SQLite development is quite conservative and probably won't break compatibility in another 50 years :) would still be good to address this, maybe in a separate PR though.

@jberkel
Copy link
Collaborator Author

jberkel commented Oct 9, 2016

@mbarclay FYI #517

@jberkel
Copy link
Collaborator Author

jberkel commented Oct 9, 2016

closing in favor of #502

@jberkel jberkel closed this Oct 9, 2016
@jberkel jberkel deleted the xcode8 branch October 11, 2016 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jberkel @stephencelis @mbarclay