version check #434
Merged
version check #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I love this addition! I also like that the check is disabled by default, so we are only requesting stuff in the background if the user "permits" and actually wants it. The only thing I would reconsider is the use of Either via the git tag: curl https://api.github.com/repos/hopsoft/stimulus_reflex/tagsor via the GitHub releases: curl https://api.github.com/repos/hopsoft/stimulus_reflex/releases/latest |
…#479) * don't run on every attribute change (just `data-reflex` and `data-action`) Co-authored-by: leastbad <38150464+leastbad@users.noreply.github.com>
Fix broken link in docs
add `useReflex` js function to "support" the composable pattern
…mulusreflex#486) * Restructure receive * Extract ReflexData and ReflexFactory
…timulusreflex#438) Co-authored-by: Marco Roth <marco.roth@intergga.ch>
…into version_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Enhancement
Description
During Rails startup, phone home to Github and compare local version against
LATEST.Adds new
config.on_new_version_availableflag to SR initializer which can be :exit, :warn or :ignore.Defaults to :ignore (no connection attempted). Test only runs in development mode.
Network call is set to timeout 1s connect, 1s read (2s total).
Test will emit a message about skipping checks if running a pre-release build.
Test will not run if sanity checks are set to :ignore, regardless of
on_new_version_availablesetting.Updating
LATESTwill have to become part of the version deployment process.Fixes #433
Why should this be added
This should be recommended to users struggling with keeping versions up to date. Goal is to reduce support version.
Checklist