Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add icon and color #2

Merged
merged 1 commit into from
Sep 19, 2024
Merged

chore: add icon and color #2

merged 1 commit into from
Sep 19, 2024

Conversation

adthrasher
Copy link
Member

Apparently, best practices for GitHub Actions include an icon and a color. I've somewhat arbitrarily chosen this icon and color.

You can checkout the available colors and icons in the marketplace: https://github.com/marketplace?type=actions. Here is an action that has the same icon (though in white): https://github.com/marketplace/actions/super-linter.

@adthrasher adthrasher requested a review from a-frantz September 19, 2024 13:22
@adthrasher adthrasher self-assigned this Sep 19, 2024
Copy link
Member

@a-frantz a-frantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This icon seems fine to me, but I wonder if we can use the sprocket logo? If it's a hassle to get that uploaded or whatever, don't worry about it.

@adthrasher
Copy link
Member Author

This icon seems fine to me, but I wonder if we can use the sprocket logo? If it's a hassle to get that uploaded or whatever, don't worry about it.

I think the only way to get a custom icon is to go through a partner verification step. I don't see any documentation about icons and colors, except a prompt when going through the process to release an action. This document mentions badges for verified creators: https://docs.github.com/en/actions/sharing-automations/creating-actions/publishing-actions-in-github-marketplace#about-badges-in-github-marketplace

@a-frantz
Copy link
Member

Yea, I would consider that to be a hassle and not worth it (at this time).

@adthrasher adthrasher merged commit d5f2160 into main Sep 19, 2024
@adthrasher adthrasher deleted the adthrasher-patch-1 branch September 19, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants