Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate import strings during AST validation #152

Closed
a-frantz opened this issue Aug 1, 2024 · 0 comments · Fixed by #158
Closed

Validate import strings during AST validation #152

a-frantz opened this issue Aug 1, 2024 · 0 comments · Fixed by #158

Comments

@a-frantz
Copy link
Member

a-frantz commented Aug 1, 2024

There are expect() statements in wdl-format (#133) that can currently panic as their assumptions are only validated in analysis. Those checks should move to AST validation.

@a-frantz a-frantz mentioned this issue Aug 1, 2024
8 tasks
peterhuene added a commit to peterhuene/wdl that referenced this issue Aug 13, 2024
This commit moves the validation of imports from `wdl-anlaysis` to `wdl-ast`
where the rest of the validation visits occur.

Fixes stjude-rust-labs#152.
peterhuene added a commit to peterhuene/wdl that referenced this issue Aug 13, 2024
This commit moves the validation of imports from `wdl-anlaysis` to `wdl-ast`
where the rest of the validation visits occur.

Fixes stjude-rust-labs#152.
peterhuene added a commit to peterhuene/wdl that referenced this issue Aug 13, 2024
This commit moves the validation of imports from `wdl-anlaysis` to `wdl-ast`
where the rest of the validation visits occur.

Fixes stjude-rust-labs#152.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant