Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint warning for inputs and parameter_meta being in a different order #259

Open
a-frantz opened this issue Nov 25, 2024 · 1 comment
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@a-frantz
Copy link
Member

a-frantz commented Nov 25, 2024

This should already exist but is not firing in my IDE. I think this is an oversight in the MatchingParameterMeta rule.

input declaration and parameter_meta definition should be in the same order. As in, the below should fire a lint note about being "out of order"

workflow foo {
    parameter_meta {
        b: "The second input"
        a: "The first input"
    }
    input {
        Int a
        Int b
    }
}
@a-frantz a-frantz added bug Something isn't working good first issue Good for newcomers labels Nov 25, 2024
@prathmesh703
Copy link

@a-frantz can i give a try to resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@a-frantz @prathmesh703 and others