-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: call_input_spacing rule #102
Conversation
@a-frantz - This one is likely to end up being controversial given the number of new entries in Arena. |
4ca3378
to
d5773e8
Compare
wdl-lint/tests/lints/missing-meta-and-parameter_meta/source.errors
Outdated
Show resolved
Hide resolved
Yea, and I think anytime we're about to add a bunch of entries to Arena we should step back and think hard before hitting merge. That said I think these numbers are slightly inflated by your implementation "double-reporting" certain spans? Maybe we should cap it at one diagnostic per-call-statement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty solid! Just a few feedback comments.
Co-authored-by: Peter Huene <peter@huene.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(can you refresh base gauntlet to get the latest workflows
hash?)
Other than that this LGTM.
This pull request adds a new rule to
wdl-lint
.CallInputSpacing
Ensures that the
input
keyword follows the opening brace and exactly one space. Ensures that if more than oneinput
exists, they are on separate lines. Ensures that the assignment operator ("=") is surrounded by whitespace.Before submitting this PR, please make sure:
CHANGELOG.md
(see["keep a changelog"] for more information).
Rule specific checks:
RULES.md
.rules()
function inwdl-lint/src/lib.rs
.wdl-lint/tests/lints
that covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.
wdl-gauntlet --refresh
to ensure that there are nounintended changes to the baseline configuration file (
Gauntlet.toml
).wdl-gauntlet --refresh --arena
to ensure that all of therules added/removed are now reflected in the baseline configuration file
(
Arena.toml
).