Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inconsistent_newlines rule #104

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Conversation

adthrasher
Copy link
Member

This pull request adds a new rule to wdl-lint.

  • Rule Name: InconsistentNewlines

This rule checks for usage of both "\r\n" and "\n".

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added an entry to the relevant CHANGELOG.md (see
    ["keep a changelog"] for more information).
  • Your commit messages follow the [conventional commit] style.

Rule specific checks:

  • You have added the rule as an entry within RULES.md.
  • You have added the rule to the rules() function in wdl-lint/src/lib.rs.
  • You have added a test cases in wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.
  • You have run wdl-gauntlet --refresh to ensure that there are no
    unintended changes to the baseline configuration file (Gauntlet.toml).
  • You have run wdl-gauntlet --refresh --arena to ensure that all of the
    rules added/removed are now reflected in the baseline configuration file
    (Arena.toml).

@adthrasher adthrasher requested review from peterhuene and a-frantz and removed request for peterhuene June 26, 2024 19:20
@adthrasher adthrasher self-assigned this Jun 26, 2024
@adthrasher adthrasher requested a review from peterhuene June 26, 2024 19:20
@adthrasher adthrasher marked this pull request as ready for review June 26, 2024 19:20
Copy link
Collaborator

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few feedback comments to resolve.

wdl-lint/src/rules/inconsistent_newlines.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/inconsistent_newlines.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/inconsistent_newlines.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/inconsistent_newlines.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/inconsistent_newlines.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@adthrasher adthrasher merged commit 5e43835 into main Jun 27, 2024
7 checks passed
@adthrasher adthrasher deleted the feat/inconsistent_newlines branch June 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants