-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: section ordering lint rule #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this. I'd take a look at my question about which span to report and also removing the println!
. One last thing to consider is whether we want to report in the fix only the sections that were actually detected rather than a static list of all possible sections. I don't think that's required, but it might be just a tad bit cleaner—if nothing else, for future work.
Ah, also need to add this when #110 is merged in. You probably want to rebase on that branch, as doing the inverse would be difficult.
|
I'm happy to also rebase my branch if we want to merge this first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, just a few comments for your review.
Co-authored-by: Peter Huene <peter@huene.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This pull request adds a new rule to
wdl-lint
.SectionOrdering
This rule ensures that tasks and workflows have their sections in the desired order.
Before submitting this PR, please make sure:
CHANGELOG.md
(see["keep a changelog"] for more information).
Rule specific checks:
RULES.md
.rules()
function inwdl-lint/src/lib.rs
.wdl-lint/tests/lints
that covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.
wdl-gauntlet --refresh
to ensure that there are nounintended changes to the baseline configuration file (
Gauntlet.toml
).wdl-gauntlet --refresh --arena
to ensure that all of therules added/removed are now reflected in the baseline configuration file
(
Arena.toml
).