Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SectionOrder): allow workflow conditionals #129

Merged
merged 4 commits into from
Jul 16, 2024
Merged

fix(SectionOrder): allow workflow conditionals #129

merged 4 commits into from
Jul 16, 2024

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Jul 16, 2024

Also allow hints sections

Describe the problem or feature in addition to a link to the issues.
Fixes the SectionOrder rule so that it doesn't fire on every WorkflowItem::Conditional. While I was at it I tweaked the language of explanation() and permitted hints sections.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

@a-frantz a-frantz self-assigned this Jul 16, 2024
@a-frantz a-frantz marked this pull request as ready for review July 16, 2024 15:04
wdl-lint/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@claymcleod claymcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@a-frantz a-frantz merged commit 2da59bc into main Jul 16, 2024
7 checks passed
@a-frantz a-frantz deleted the a-frantz/fix branch July 16, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants