Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/expression spacing #134

Merged
merged 23 commits into from
Jul 31, 2024
Merged

Feat/expression spacing #134

merged 23 commits into from
Jul 31, 2024

Conversation

adthrasher
Copy link
Member

@adthrasher adthrasher commented Jul 18, 2024

This pull request adds a new rule to wdl-lint.

  • Rule Name: ExpressionSpacing

Enforces spacing in expressions

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added an entry to the relevant CHANGELOG.md (see
    ["keep a changelog"] for more information).
  • Your commit messages follow the [conventional commit] style.

Rule specific checks:

  • You have added the rule as an entry within RULES.md.
  • You have added the rule to the rules() function in wdl-lint/src/lib.rs.
  • You have added a test case in wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.
  • If you have implemented a new Visitor callback, you have also
    overridden that callback method for the special Validator
    (wdl-ast/src/validation.rs) and LintVisitor
    (wdl-lint/src/visitor.rs) visitors. These are required to ensure the new
    visitor callback will execute.
  • You have run wdl-gauntlet --refresh to ensure that there are no
    unintended changes to the baseline configuration file (Gauntlet.toml).
  • You have run wdl-gauntlet --refresh --arena to ensure that all of the
    rules added/removed are now reflected in the baseline configuration file
    (Arena.toml).

@adthrasher adthrasher self-assigned this Jul 18, 2024
@adthrasher adthrasher marked this pull request as ready for review July 24, 2024 17:54
Copy link
Member

@a-frantz a-frantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this! This is a complicated rule. Mostly just nits.

wdl-lint/src/rules/expression_spacing.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/expression_spacing.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/expression_spacing.rs Show resolved Hide resolved
wdl-lint/src/rules/expression_spacing.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/expression_spacing.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/expression_spacing.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/expression_spacing.rs Outdated Show resolved Hide resolved
wdl-lint/src/rules/expression_spacing.rs Show resolved Hide resolved
Copy link
Member

@a-frantz a-frantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more nitpick on the line breaks in explanation().

wdl-lint/src/rules/expression_spacing.rs Outdated Show resolved Hide resolved
@adthrasher adthrasher merged commit 5d48940 into main Jul 31, 2024
8 checks passed
@adthrasher adthrasher deleted the feat/expression-spacing branch July 31, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants