-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init wdl-doc #248
feat: init wdl-doc #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just some nit picky comments.
Co-authored-by: Peter Huene <peter@huene.dev>
>&2 echo "But number must be less than 4096!" | ||
exit 42 | ||
fi | ||
elif [[ "~{number}" =~ ^0[0-7]{0,4}$ ]] \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought for the future—it may be worth pulling in the St. Jude Cloud workflows as a submodule here for a more complete picture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good after these.
Describe the problem or feature in addition to a link to the issues.
This is a very rough init commit for
wdl-doc
. All the current HTML output is going to be thrown out and reimplemented once we have the templates from the designers, so I wouldn't spend much time combing through that with a fine-tooth comb.The most important bit included in this PR is the resulting output directory structure created in
wdl-doc/src/lib.rs
.Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md
(see"keep a changelog" for more information).